Summary

Fix post-review for bare hostnames

Review Request #1754 — Created Aug. 31, 2010 and submitted

Information

Owner

coderanger

Repository

RBTools

Branch

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

cookielib automatically appends .local to any hostname with no '.'s, presumably because Mozilla does the same. This breaks the cookie lookup for something like http://reviews/.

Testing Done

Been using this internally for some time now.

Expand All
Collapse All

Ship it!

Now I know why it doesn't work for local domains.

Looks like there is a reason behind it:
http://www.ietf.org/rfc/rfc2965.txt

Ship it!

Looks good. Committed to master as rf59e732. Thanks!