Add Bazaar support to post-review

Review Request #1739 — Created Aug. 19, 2010 and discarded

gustavo
RBTools
773
rbtools
This patch adds Bazaar support to post-review.

Please let me know what you think and how it can be improved.
I've written tests and also done manual testing. It's been tested with Bazaar 2.1.2 and Python 2.5.4, on Ubuntu 9.10.
GU
JU
  1. 
      
  2. rbtools/postreview.py (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
    This regexp doesn't seem to work in all cases.  My `bzr info` output looks like this:
    
      Repository checkout (format: 2a)
      Location:
        repository checkout root: .
              checkout of branch: bzr+ssh://server/db/repo/trunk/
               shared repository: /home/julian/source/repo
    
      Related branches:
        submit branch: /home/julian/source/repo/branches/stage1
    
  3. 
      
SM
  1. Thanks for doing this, I've got your code working on windows 7 with bzr 2.2.0, but I had to do two little hacks to get it to work.
  2. rbtools/postreview.py (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
    Had to change the regex to
    BRANCH_REGEX = r'\w*(branch|branch root): (?P<branch_path>.+)$' 
    to get it to work in my case. 
    
    The output of bzr info was:
    Repository checkout (format: 2a)
    Location:
      repository checkout root: .
            checkout of branch: bzr://<my_remote_repo>
             shared repository: C:/<my_local_folder>
  3. rbtools/postreview.py (Diff revision 2)
     
     
    I don't think this work if you're in a repo without a branch.
  4. 
      
GU
Review request changed

Status: Discarded

Loading...