Perforce: Speed up creating review request diff for a path/range diff

Review Request #1734 — Created Aug. 11, 2010 and submitted

Faller.Gyula
RBTools
rbtools
If you posting a review request in a Perforce workspace from a range of changes for a range of files, and not only one changelist, it is very slow now, since it diffs all the files in the range.
But there is speed up: When the revision numbers equal in Perforce, the two files are identical, by definition.


FA
  1. 
      
  2. rbtools/postreview.py (Diff revision 1)
     
     
    If revisions equal, there is no change, do not try to make a diff for it.
  3. 
      
david
  1. Looks good. Submitted as r6d6c7b6. Thanks!
  2. 
      
Loading...