Better handle stripping CVSROOTs from CVS paths.

Review Request #1684 — Created June 26, 2010 and submitted


Review Board


Better handle stripping CVSROOTs from CVS paths.

We had code to strip the absolute path prefixes from CVS paths in diffs,
but it didn't handle CVSROOTs that didn't separate the domain and path
with a ':'. We now handle this case a bit better by finding where that
path begins.

Also fixes a bug where the attic filename was being generated incorrectly
if the file didn't contain a '/' in the name.
Tested with a diff I was working with locally. I no longer had errors when viewing it with my repository.
  1. Looks good. Should this have any bugs marked?
    1. Not that I've seen. I think everyone pretty much uses the ":" delimiter, while we don't appear to include that when we build the path. So it's triggered by our new CVS stuff on SourceForge, basically, which I imagine isn't strongly used.