--revision-range and --summary options for post-review script

Review Request #168 — Created Oct. 7, 2007 and submitted

philn
Review Board SVN (deprecated)
reviewboard
This patch adds 2 new options: --revision-range and --summary. Revision range option is implemented only for the SVNClient.
I also set the locale to C so that we get svn diff output suitable for reviewboard.


chipx86
  1. Wow, I apparently never published this review. I just noticed it was still a draft.
    
    Anyhow, if you can update this with the latest post-review and address these issues, I'll try to get this in soon :)
  2. trunk/reviewboard/contrib/tools/post-review (Diff revision 1)
     
     
     
     
    Looks like this is left over from your customized version of the tool.
    1. Yeah sorry about that ;)
  3. I'm not sure I understand the desire for this. What if the files being modified have UTF-8 data in it?
    1. Well the fact it that the svn diff parser is based on regexes. If I use the french locale, reviewboard won't be able to parse the the svn diff output because for instance, in the french locale "Revision" is "RĂ©vision".
      
      But yeah I agree to remove that line, the "svn diff" / locale bug should be adressed separately.
  4. 
      
david
  1. Committed to svn with very minor style changes.  Thanks!
  2. 
      
Loading...