post-review modification to recognise moved/renamed files in Perforce repository and treat them similarly to deleted files

Review Request #1654 — Created June 10, 2010 and submitted

Information

RBTools

Reviewers

Files that have been renamed or moved in a Perforce depot appear with the 'move/delete' action, and not just 'delete'.  This modification ensures that post-review recognises these correctly and removes them from the diff listings.
Tested with latest Reviewboard install, against a production perforce server.  The script now correctly does not show renamed/ moved files in the diff lists, where they were appearing before.
GO
Review request changed
Description:
~  

Files that renamed/ moved in Perforce appear with the 'move/delete' action, and not just 'delete'. This modification ensures that post-review recognises these correctly and removes them from the diff listings.

  ~

Files that have been renamed or moved in a Perforce depot appear with the 'move/delete' action, and not just 'delete'. This modification ensures that post-review recognises these correctly and removes them from the diff listings.

BH
  1. 
      
  2. rbtools/postreview.py (Diff revision 1)
     
     
     
    Whitespace at the end of the line, and the "):" shouldn't be on a new line (I think).
  3. rbtools/postreview.py (Diff revision 1)
     
     
    Whitespace at the end of the line.
  4. 
      
chipx86
  1. Committed a variation on this to RBTools (029887899a3a0e3fccbf9e887efc075fc78be4fb).
  2.