Add Egg Template Loader to Review Board TEMPLATE_LOADERS

Review Request #1625 — Created May 31, 2010 and submitted

Information

Review Board
extensions

Reviewers

In order to load templates from eggs, we need the Egg Template Loader.

This patch relies on code under review here:  http://reviews.reviewboard.org/r/1623
Manual - and works like a charm.
chipx86
  1. 
      
  2. reviewboard/settings.py (Diff revision 1)
     
     
    There's an extension-specific template loader in djblets.extensions.loaders that was originally intended to be used as a replacement for the egg loader. The original reason for it was to loop through the extensions themselves. The egg one works because things are now in INSTALLED_APPS, but it may be worthwhile to use the custom Djblets one so that we don't end up with some template otherwise installed from an egg due to a name collision (such as one living in Djblets that an extension would want to provide).
  3. 
      
mike_conley
Review request changed

Change Summary:

Switching to the custom Djblets extension template loader.  Still seems to work alright.

Diff:

Revision 2 (+1 -1)

Show changes

chipx86
  1. Thanks! Committed to extensions (c0f7614)
  2. 
      
Loading...