Fix import errors of get_package_verion and get_version_string

 






 

 


  Review Request #1622
  —
  Created May 30, 2010 and discarded

 


















 

  

   Information

  





 
 

  keyboard
 









 
 

  RBTools
 









 
 

  
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Fix import errors of get_package_verion and get_version_string

On a fresh "git clone" of the repository, running postreview.py will bail out because it can't find get_package_version or get_version_string.  This patch simply adds the script's parent directory to the search path.

 








  


 
 

  
Tested that the following sequence works on Linux without errors:

git clone git://github.com/reviewboard/rbtools.git
export PATH="${PATH}:$(pwd)/rbtools/rbtools"
apply patch
git add rbtools/rbtools/postreview.py
git ci
postreview.py --guess-summary --guess-description

 







 









 





  








 









 






  

 








 














 





 

  

   




chipx86




   

   





  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    I know this has been here a while, but our concentration hasn't been on RBTools lately.

We actually don't want postreview.py to be run directly. We'll be modularizing it and you'll need to follow a different route. You should either do a normal install or "setup.py develop", which will cause a /usr/bin/post-review (or similar) that invokes the version from the tree, with the correct paths.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 









     

    

   

  

  

   
   Loading...