Automatically disable dependent extensions

Review Request #1594 — Created May 17, 2010 and discarded

Information

Djblets
extensions

Reviewers

When an extension is disabled, all of the extensions that depend on this extension should also be disabled.

I've added a function called get_dependent_extensions that returns a list of dependent extension_id's.  Unfortunately, pkg_resources wouldn't give me this list easily, so I had to generate it myself.  I could probably use some fancy list-comprehension to squash that double for-loop, but I figure this one is more readable.

Once again, open to all suggestions and feedback.
Manual - still trying to figure out the best way to test this.
david
  1. 
      
  2. djblets/extensions/base.py (Diff revision 1)
     
     
     
     
     
     
     
    Indent 4 spaces.
  3. djblets/extensions/base.py (Diff revision 1)
     
     
     
    Indent 4 spaces.
  4. 
      
mike_conley
david
  1. 
      
  2. 
      
chipx86
  1. 
      
  2. djblets/extensions/base.py (Diff revision 2)
     
     
    Use iteritems instead of items.
  3. djblets/extensions/base.py (Diff revision 2)
     
     
     
    Blank line between these.
  4. 
      
mike_conley
Review request changed

Change Summary:

Thanks for the feedback - made those corrections.

Also updated to suit http://reviews.reviewboard.org/r/1590/ - which is this diff's ancestor.

Diff:

Revision 3 (+24)

Show changes

Loading...