-
-
/trunk/reviewboard/contrib/tools/post-review (Diff revision 1) The indentation looks a bit screwed up here.
-
/trunk/reviewboard/contrib/tools/post-review (Diff revision 1) One thing we'll need to make sure we support is spaces in the filename. It looks like this may break in this case.
Add Perforce submitted changelist support to post-review.
Review Request #158 — Created Oct. 1, 2007 and submitted
Information | |
---|---|
ehuss | |
Review Board SVN (deprecated) | |
Reviewers | |
reviewboard | |
- Support submitted changelists in Perforce. - Silence subversion warning message when not using subversion. - Fix some minor bugs (improperly referenced variables). - Verify change number is an integer and give a friendly error message. - Support BSD style diff timestamps.
Posted pending and submitted changelists in Perforce. Posted a normal change in subversion (this change, in fact). Tested on FreeBSD (hence the BSD support), but have not tested on Linux. Should not be a factor, I just don't have a Linux box handy to test on.