-
-
-
contrib/internal/devserver.py (Diff revision 1) Two blank lines between the imports and the constants, and two between constants and functions.
-
contrib/internal/devserver.py (Diff revision 1) Two blank lines between functions outside of a class.
-
contrib/internal/devserver.py (Diff revision 1) One blank line before blocks (for loops, if statements, etc.)
-
-
-
-
contrib/internal/devserver.py (Diff revision 1) For readability purposes, can you put one of these \n on its own line? Each string fragment should ideally terminate at the \n
-
-
contrib/internal/devserver.py (Diff revision 1) No need for the \ here too. I'd rather see this as: os.system('./reviewboard/manage.py ....%s' ' --adminmedia=....' % server_port)
Port devserver.sh to Python, and add optional port argument
Review Request #1570 — Created May 2, 2010 and submitted
Information | |
---|---|
mike_conley | |
Review Board | |
master | |
1596 | |
Reviewers | |
reviewboard | |
Ported the devserver shell script to Python. Now takes optional -p parameter to set server port.
Tested manually. I ran from other directories, and moved various folders in order to trigger the error messages, and they all seem to do the job.