Summary

Port devserver.sh to Python, and add optional port argument

Review Request #1570 — Created May 2, 2010 and submitted

Information

Owner

mike_conley

Repository

Review Board

Branch

master

Bugs

1596

Depends On

Reviewers

Groups

reviewboard

People

Description

Ported the devserver shell script to Python.  Now takes optional -p parameter to set server port.

Testing Done

Tested manually.  I ran from other directories, and moved various folders in order to trigger the error messages, and they all seem to do the job.

contrib/internal/devserver.py (Diff revision 1)
```
Imports should be in alphabetical order.
```
1. mike_conley May 3, 2010, 2:08 a.m.
  Done

contrib/internal/devserver.py (Diff revision 1)

Two blank lines between the imports and the constants, and two between constants and functions.

mike_conley May 3, 2010, 2:08 a.m.
```
Done
```

contrib/internal/devserver.py (Diff revision 1)
```
Two blank lines between functions outside of a class.
```
1. mike_conley May 3, 2010, 2:09 a.m.
  Done
contrib/internal/devserver.py (Diff revision 1)
```
One blank line before blocks (for loops, if statements, etc.)
```
1. mike_conley May 3, 2010, 2:09 a.m.
  Done

contrib/internal/devserver.py (Diff revision 1)

Make sure we have \n in the right places.

mike_conley May 3, 2010, 2:10 a.m.

I've updated the string to have the \n in the same places as devserver.sh,

contrib/internal/devserver.py (Diff revision 1)
```
No need for the \ here.
```
1. mike_conley May 3, 2010, 2:10 a.m.
  Done
contrib/internal/devserver.py (Diff revision 1)
```
Here too.
```
1. mike_conley May 3, 2010, 2:10 a.m.
  Done

contrib/internal/devserver.py (Diff revision 1)

For readability purposes, can you put one of these \n on its own line? Each string fragment should ideally terminate at the \n

mike_conley May 3, 2010, 2:10 a.m.
```
Done
```

contrib/internal/devserver.py (Diff revision 1)
```
No need for the \, since it's in parens.
```
1. mike_conley May 3, 2010, 2:10 a.m.
  Done

contrib/internal/devserver.py (Diff revision 1)

No need for the \ here too.

I'd rather see this as:

os.system('./reviewboard/manage.py ....%s'
          ' --adminmedia=....'
          % server_port)

mike_conley May 3, 2010, 2:10 a.m.
```
and done
```

Change Summary:

Style changes in response to review.

Diff:

Revision 2 (+75 -31)

Show changes

	contrib/internal/devserver.py
	contrib/internal/devserver.sh

Ship it!

Looks good, thanks! Committed to master (cbebd04)