• 
      

    Allow comments on rendered Markdown in the diff viewer.

    Review Request #15539 — Created Nov. 16, 2026 and updated

    Information

    Review Board
    release-9.x

    Reviewers

    This change makes it so users can add comments on the rendered view of
    Markdown files in the diff viewer. Like comments on rendered Markdown
    file attachments, they store viewMode and renderVersion in
    extra_data, and their line numbers refer to rows in the rendered diff.

    Because lines don't necessarily map cleanly between views, comment flags
    are only shown in the matching view. In published reviews, comments get
    grouped by the view mode, so that source and rendered comments on the
    same row numbers stay distinct.

    • Ran unit tests.
    • Ran js tests.
    • Added comments to both the source and rendered version of markdown
      files in a code change.
    Summary ID
    Allow comments on rendered Markdown in the diff viewer.
    This change makes it so users can add comments on the rendered view of Markdown files in the diff viewer. Like comments on rendered Markdown file attachments, they store `viewMode` and `renderVersion` in extra_data, and their line numbers refer to rows in the rendered diff. Because lines don't necessarily map cleanly between views, comment flags are only shown in the matching view. In published reviews, comments get grouped by the view mode, so that source and rendered comments on the same row numbers stay distinct. Testing Done: - Ran unit tests. - Ran js tests.
    ouzzqpnqntnxxqoonovyvuksozsuwxrw
    Description From Last Updated

    Something that would be nice is to have the comment links open to the rendered view if it's a rendered …

    maubin maubin
    Checks run (2 succeeded)
    flake8 passed.
    JSHint passed.
    maubin
    1. 
        
    2. Show all issues

      Something that would be nice is to have the comment links open to the rendered view if it's a rendered comment. Right now we always open to the source view and then it highlights a most a row that's most likely unrelated to the actual comment. Not a huge deal but just an idea.

      1. That's coming in a change that I haven't yet posted.

    3. 
        
    maubin
    1. Ship It!
    2.