Summary

Optimize get_url_params_except().

Review Request #15392 — Created Oct. 12, 2026 and updated Oct. 12, 2026, 8:51 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

get_url_params_except() iterated through the provided list of query
argument exceptions for every key in the query string. This was more
inefficient the more the larger the exception list.

We now convert this to a set before iteration begins, making lookups
more cheap.

Testing Done

Unit tests pass.

Commits

Summary	ID
Optimize get_url_params_except(). `get_url_params_except()` iterated through the provided list of query argument exceptions for every key in the query string. This was more inefficient the more the larger the exception list. We now convert this to a `set` before iteration begins, making lookups more cheap.	2d5edcecc7d288b455836a67ba10478231494390

flake8 passed.

JSHint passed.

Expand All
Collapse All