Branch: |
|
---|
patch for perforce. If changing the security level of perforce server, perhaps fail to login perforce when creating diffs.
Review Request #1537 — Created April 27, 2010 and discarded
patch for perforce. If changing the security level of perforce server, perhaps fail to login perforce when creating diffs.
-
-
reviewboard/scmtools/perforce.py (Diff revision 1) We can't use echo like this. We might not be running on a system where it works. Please use the p4 api if at all possible, too.
SE
Description: |
|
---|
SE
Description: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+9 -2) |
SE
-
-
reviewboard/scmtools/perforce.py (Diff revision 3) Must restore password after executing p4.run_login(), or will fail to post requests. Don't know the reason. it seems to be a bug of p4svn.
AR
-
Using "p4 login" is what my patch (http://reviews.reviewboard.org/r/1445/) also does. It should now include all of the changes Christian requested some time ago. What it does different is that it won't enforce "p4 login" but makes it optional depending on a configuration setting. What I don't understand is why you call the login command with each connect. Running the login command should replace both user and password attributes of the p4 class with the ticket credentials so those will be used for further p4 calls. I don't see the necessity to redo that step with each connect.