• 
      

    Bring over improvements made to the client login flow in RBCommons.

    Review Request #15320 — Created Sept. 17, 2026 and updated

    Information

    Review Board
    release-9.x

    Reviewers

    RBCommons 8 added support for the client login flow, which was released
    in Review Board 5.0.5. RBCommons needed some special handling in order
    to make things work with it's two-factor authentication. While working
    on that, some improvements to the general client login flow code were made:

    • Guarding against a client url that has an invalid port.
    • Encoding the client name, client URL query strings.
    • Adding more unit tests.

    This change brings those in to the Review Board client login flow. While
    here I noticed the centering for the messages after success/failed client
    log ins got affected from some changes to our auth forms CSS, so this
    addresses that too.

    • Ran unit tests.
    • Tested the client login flow while logged in and
      logged out.
    Summary ID
    Bring over improvements made to the client login flow in RBCommons.
    RBCommons 8 added support for the client login flow, which was released in Review Board 5.0.5. RBCommons needed some special handling in order to make things work with it's two-factor authentication. While working on that, some improvements to the general client login flow code were made: - Guarding against a client url that has an invalid port. - Encoding the client name, client URL query strings. - Adding more unit tests. This change brings those in to the Review Board client login flow.
    bb81238a55d977285a1ddcf80834fb2ac4ded4a6
    Checks run (2 succeeded)
    flake8 passed.
    JSHint passed.