Summary

Add GitHub App connectivity.

Review Request #15227 — Created Aug. 13, 2026 and submitted Aug. 31, 2026, 9:19 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-9.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This also includes a BaseHostingServiceConnectUI subclass for GitHub
that wires all of that into the connect wizard and provides some custom
UI for the GitHub entry in the connected services list.

Testing Done


Connected a GitHub App and installed it into multiple organizations.
Tested all aspects of the wizard flow, including creation of the app

  and reassignment of any PAT-based repositories after app install.
Verified that API access works correctly when authenticating using the

  app tokens.
Ran unit tests.

Commits

Summary	ID
Add GitHub App connectivity. This change adds the connection flow and UI for using GitHub Apps. This involves a new set of views that deal with the mechanics of triggering the app creation, processing the result, and triggering an app install. This also includes a BaseHostingServiceConnectUI subclass for GitHub that wires all of that into the connect wizard and provides some custom UI for the GitHub entry in the connected services list. Testing Done: - Connected a GitHub App and installed it into multiple organizations. - Tested all aspects of the wizard flow, including creation of the app and reassignment of any PAT-based repositories after app install. - Verified that API access works correctly when authenticating using the app tokens. - Ran unit tests.	yuvyttvstzusktvqqtsquwwkvvzuwqmz

Summary

Add GitHub App connectivity.

This change adds the connection flow and UI for using GitHub Apps. This involves a new set of views that deal with the mechanics of triggering the app creation, processing the result, and triggering an app install. This also includes a BaseHostingServiceConnectUI subclass for GitHub that wires all of that into the connect wizard and provides some custom UI for the GitHub entry in the connected services list. Testing Done: - Connected a GitHub App and installed it into multiple organizations. - Tested all aspects of the wizard flow, including creation of the app and reassignment of any PAT-based repositories after app install. - Verified that API access works correctly when authenticating using the app tokens. - Ran unit tests.

yuvyttvstzusktvqqtsquwwkvvzuwqmz

Issues

Description	From	Last Updated
This is missing a "Version Added".	chipx86	Aug. 21, 2026, 8:49 a.m.
This is missing the full module path.	chipx86	Aug. 21, 2026, 8:50 a.m.
Can we sort this in alphabetical order?	chipx86	Aug. 21, 2026, 8:50 a.m.
These are kind of jumbled. The github ones should go together. Probably easiest just to sort them.	chipx86	Aug. 21, 2026, 8:50 a.m.
Can we sort these?	chipx86	Aug. 21, 2026, 8:50 a.m.
I'm assuming one of the follow-up changes removes this (or it's meant to be removed in this change). But maybe …	chipx86	Aug. 21, 2026, 8:50 a.m.
Can we assert the entirety of github_app so it's clear what tests are affected if need to add to the …	chipx86	Aug. 21, 2026, 8:56 a.m.
Can we sort alphabetically?	chipx86	Aug. 21, 2026, 8:56 a.m.
Can we pull accounts[0] out into a variable to avoid the repeated indexes?	chipx86	Aug. 21, 2026, 8:57 a.m.
Can we pull installations[0] out into a variable to avoid the repeated indexes?	chipx86	Aug. 21, 2026, 8:57 a.m.
For here and elsewhere (I forget where else I saw these), Django provides a utility. The class can mix in …	chipx86	Aug. 21, 2026, 9:03 a.m.

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Add GitHub App connectivity. This change adds the connection flow and UI for using GitHub Apps. This involves a new set of views that deal with the mechanics of triggering the app creation, processing the result, and triggering an app install. This also includes a BaseHostingServiceConnectUI subclass for GitHub that wires all of that into the connect wizard and provides some custom UI for the GitHub entry in the connected services list. Testing Done: - Connected a GitHub App and installed it into multiple organizations. - Tested all aspects of the wizard flow, including creation of the app and reassignment of any PAT-based repositories after app install. - Verified that API access works correctly when authenticating using the app tokens. - Ran unit tests.	yuvyttvstzusktvqqtsquwwkvvzuwqmz
	Add GitHub App connectivity. This change adds the connection flow and UI for using GitHub Apps. This involves a new set of views that deal with the mechanics of triggering the app creation, processing the result, and triggering an app install. This also includes a BaseHostingServiceConnectUI subclass for GitHub that wires all of that into the connect wizard and provides some custom UI for the GitHub entry in the connected services list. Testing Done: - Connected a GitHub App and installed it into multiple organizations. - Tested all aspects of the wizard flow, including creation of the app and reassignment of any PAT-based repositories after app install. - Verified that API access works correctly when authenticating using the app tokens. - Ran unit tests.	yuvyttvstzusktvqqtsquwwkvvzuwqmz

Diff:

Revision 2 (+6252 -78)

Show changes

	reviewboard/admin/tests/test_connect_service_view.py
	reviewboard/hostingsvcs/github/api.py
	reviewboard/hostingsvcs/github/client.py
	reviewboard/hostingsvcs/github/service.py
	reviewboard/hostingsvcs/github/views.py
	reviewboard/hostingsvcs/tests/github/base.py
	reviewboard/hostingsvcs/tests/github/test_app.py
	reviewboard/hostingsvcs/tests/github/test_app_views.py
	6 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/hostingsvcs/github/client.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This is missing a "Version Added".
```
reviewboard/hostingsvcs/github/service.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This is missing the full module path.
```
reviewboard/hostingsvcs/github/service.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can we sort this in alphabetical order?
```

reviewboard/hostingsvcs/github/service.py (Diff revision 2)

The issue has been resolved. Show all issues

These are kind of jumbled. The github ones should go together. Probably easiest just to sort them.

reviewboard/hostingsvcs/github/views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can we sort these?
```

reviewboard/hostingsvcs/github/views.py (Diff revision 2)

The issue has been dropped. Show all issues

I'm assuming one of the follow-up changes removes this (or it's meant to be removed in this change). But maybe a good flag would be not settings.PRODUCTION.

david

Aug. 21, 2026, 9:13 a.m.
```
Yes, this will be removed soon.
```

reviewboard/hostingsvcs/tests/github/test_app_views.py (Diff revision 2)

The issue has been resolved. Show all issues

Can we assert the entirety of github_app so it's clear what tests are affected if need to add to the state? (An example might be a KID reference for any encryption in the future as we move away from encrypt_password.)

reviewboard/hostingsvcs/tests/github/test_app_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can we sort alphabetically?
```
reviewboard/hostingsvcs/tests/github/test_app_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can we pull accounts[0] out into a variable to avoid the repeated indexes?
```
reviewboard/hostingsvcs/tests/github/test_app_views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can we pull installations[0] out into a variable to avoid the repeated indexes?
```

reviewboard/hostingsvcs/tests/github/test_app_views.py (Diff revision 2)

The issue has been resolved. Show all issues

For here and elsewhere (I forget where else I saw these), Django provides a utility.
The class can mix in django.contrib.messages.test.MessagesTestMixin and then you can do:

self.assertMessages(
    response,
    '<message here>')

Commits:

	Summary	ID
	Add GitHub App connectivity. This change adds the connection flow and UI for using GitHub Apps. This involves a new set of views that deal with the mechanics of triggering the app creation, processing the result, and triggering an app install. This also includes a BaseHostingServiceConnectUI subclass for GitHub that wires all of that into the connect wizard and provides some custom UI for the GitHub entry in the connected services list. Testing Done: - Connected a GitHub App and installed it into multiple organizations. - Tested all aspects of the wizard flow, including creation of the app and reassignment of any PAT-based repositories after app install. - Verified that API access works correctly when authenticating using the app tokens. - Ran unit tests.	yuvyttvstzusktvqqtsquwwkvvzuwqmz
	Add GitHub App connectivity. This change adds the connection flow and UI for using GitHub Apps. This involves a new set of views that deal with the mechanics of triggering the app creation, processing the result, and triggering an app install. This also includes a BaseHostingServiceConnectUI subclass for GitHub that wires all of that into the connect wizard and provides some custom UI for the GitHub entry in the connected services list. Testing Done: - Connected a GitHub App and installed it into multiple organizations. - Tested all aspects of the wizard flow, including creation of the app and reassignment of any PAT-based repositories after app install. - Verified that API access works correctly when authenticating using the app tokens. - Ran unit tests.	yuvyttvstzusktvqqtsquwwkvvzuwqmz

Diff:

Revision 3 (+6290 -78)

Show changes

	reviewboard/admin/tests/test_connect_service_view.py
	reviewboard/hostingsvcs/github/api.py
	reviewboard/hostingsvcs/github/client.py
	reviewboard/hostingsvcs/github/service.py
	reviewboard/hostingsvcs/github/views.py
	reviewboard/hostingsvcs/tests/github/base.py
	reviewboard/hostingsvcs/tests/github/test_app.py
	reviewboard/hostingsvcs/tests/github/test_app_views.py
	6 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-9.x (44b6095)