• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Isolate service connect UI APIs into their own object.
    
 
    

    



 
    
 
    

  Review Request #15221
  —
  Created Aug. 11, 2026 and updated 

 
    


    




    




    






 
    
  
    
   Information

  
    



    
 
 
    
  david
 
    

    





    
 
 
    
  Review Board
 
    

    





    
 
 
    
  release-9.x
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewboard
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    In prior changes I'd added some new classmethods to BaseHostingService
    
in order to implement the new Connected Services page. As this grows,
    
it's making the hosting service even more unwieldy. This change moves
    
those out into a helper object, which can be subclassed for
    
service-specific functionality.
    
 
    

    





  

    
 
 
    
  
    Ran unit tests.
    
 
    

    




 
    

    





    
 
    




  
    
 
 
    
  


    
 
    
  
   
    

    Summary
    ID

   
    
      
  

   
    

    

     
    
      Isolate service connect UI APIs into their own object.
      
    In prior changes I'd added some new classmethods to BaseHostingService
in order to implement the new Connected Services page. As this grows,
it's making the hosting service even more unwieldy. This change moves
those out into a helper object, which can be subclassed for
service-specific functionality.

Testing Done:
Ran unit tests.
    
     
    

        		
    sponzwvpxzsmzurmzzvowpwuumkrxwzv

   
    


      
 
    

    
    
 
    

    






 









 
    

    



  
    
 
    

    


    












    
 




 

    


 













    
 



 
    
  
    
   
    



david




   
    
   
    
  
    
 
    


 
    
  
    

   
    

   
    

    
    
Review request changed
    
    
    
    
     


      


     
    
    
   
    


  
    
  
    
  
    




    



  
    
   
    
    Change Summary:
   
    
   
    
    
    Actually use the defined connect_ui_cls
    
   
    
  
    







  
    
   
    
    Commits:
   
    
   
    
    
    



    
 
    
  
   
    

    

    Summary
    ID

   
    
      
  

   
    

    

    

     
    
      Isolate service connect UI APIs into their own object.
      
    In prior changes I'd added some new classmethods to BaseHostingService
in order to implement the new Connected Services page. As this grows,
it's making the hosting service even more unwieldy. This change moves
those out into a helper object, which can be subclassed for
service-specific functionality.

Testing Done:
Ran unit tests.
    
     
    

        		
    sponzwvpxzsmzurmzzvowpwuumkrxwzv

   
    



   
    

    

    

     
    
      Isolate service connect UI APIs into their own object.
      
    In prior changes I'd added some new classmethods to BaseHostingService
in order to implement the new Connected Services page. As this grows,
it's making the hosting service even more unwieldy. This change moves
those out into a helper object, which can be subclassed for
service-specific functionality.

Testing Done:
Ran unit tests.
    
     
    

        		
    sponzwvpxzsmzurmzzvowpwuumkrxwzv

   
    


      
 
    

    


    

   
    
  
    




  
    
   
    
    Diff:
   
    
   
    
    
     Revision 2 (+544 -442)
    Show changes
     
        reviewboard/admin/views.py 
        reviewboard/hostingsvcs/base/connect_ui.py 
        reviewboard/hostingsvcs/base/hosting_service.py 
     
    
   
    
  
    





    



    
 
    
  
    Checks run (2 succeeded)
    


  
    
 flake8
 passed.
 


    


  
    
 JSHint
 passed.