Summary

Add is_nfs_path() to check if a path may be in an NFS mount.

Review Request #15191 — Created July 23, 2026 and updated July 23, 2026, 5:15 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-9.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

There are certain operations that aren't considered safe on all NFS

paths. These often involve operations where file locking is required

or the oepration is sensitive to proper synchronization. In these cases,

it can be helpful or important to log some information to help

administrators if something were to act up. This is going to be true for

the local broker.
This change introduces reviewboard.admin.server.is_nfs_path() to help

perform this check. This takes a path and checks to see if there's a

known mount point that it may live in. This is a best-effort check and

is only capable of checking Linux's /proc/mounts. On other sytsems (or

if there is an issue accessing this), this will return False.
The result is cached in an LRU cache to avoid repeated lookups for the

same paths. In practice, this is going to be used only with very few

hard-coded paths (such as a local queue path or parts of the data

directory).

Testing Done

Unit tests pass.

Commits

Summary	ID
Add is_nfs_path() to check if a path may be in an NFS mount. There are certain operations that aren't considered safe on all NFS paths. These often involve operations where file locking is required or the oepration is sensitive to proper synchronization. In these cases, it can be helpful or important to log some information to help administrators if something were to act up. This is going to be true for the local broker. This change introduces `reviewboard.admin.server.is_nfs_path()` to help perform this check. This takes a path and checks to see if there's a known mount point that it may live in. This is a best-effort check and is only capable of checking Linux's `/proc/mounts`. On other sytsems (or if there is an issue accessing this), this will return `False`. The result is cached in an LRU cache to avoid repeated lookups for the same paths. In practice, this is going to be used only with very few hard-coded paths (such as a local queue path or parts of the data directory).	94b2234d58dcbbea33ed0b66c47b61eaf770d392

Summary

Add is_nfs_path() to check if a path may be in an NFS mount.

There are certain operations that aren't considered safe on all NFS paths. These often involve operations where file locking is required or the oepration is sensitive to proper synchronization. In these cases, it can be helpful or important to log some information to help administrators if something were to act up. This is going to be true for the local broker. This change introduces `reviewboard.admin.server.is_nfs_path()` to help perform this check. This takes a path and checks to see if there's a known mount point that it may live in. This is a best-effort check and is only capable of checking Linux's `/proc/mounts`. On other sytsems (or if there is an issue accessing this), this will return `False`. The result is cached in an LRU cache to avoid repeated lookups for the same paths. In practice, this is going to be used only with very few hard-coded paths (such as a local queue path or parts of the data directory).

94b2234d58dcbbea33ed0b66c47b61eaf770d392

Issues

Description	From	Last Updated
're' imported but unused Column: 1 Error code: F401	reviewbot	July 23, 2026, 3:27 a.m.
Should be typed as Final[Pattern[str]]	david	July 23, 2026, 10:31 a.m.
This might be better named as _NFS_FS_TYPES?	david	July 23, 2026, 10:31 a.m.
Have you actually seen "efs" in the wild? I would expect EFS to show up as "nfs4" (covered by the …	david	July 23, 2026, 10:31 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/server.py (Diff revision 1)
The issue has been resolved. Show all issues
```
're' imported but unused

Column: 1
Error code: F401
```

Change Summary:

Removed an unused import.

Commits:

	Summary	ID
	Add is_nfs_path() to check if a path may be in an NFS mount. There are certain operations that aren't considered safe on all NFS paths. These often involve operations where file locking is required or the oepration is sensitive to proper synchronization. In these cases, it can be helpful or important to log some information to help administrators if something were to act up. This is going to be true for the local broker. This change introduces `reviewboard.admin.server.is_nfs_path()` to help perform this check. This takes a path and checks to see if there's a known mount point that it may live in. This is a best-effort check and is only capable of checking Linux's `/proc/mounts`. On other sytsems (or if there is an issue accessing this), this will return `False`. The result is cached in an LRU cache to avoid repeated lookups for the same paths. In practice, this is going to be used only with very few hard-coded paths (such as a local queue path or parts of the data directory).	6f88b8acaecdc9b6748077ebeafe9cc99afd6490
	Add is_nfs_path() to check if a path may be in an NFS mount. There are certain operations that aren't considered safe on all NFS paths. These often involve operations where file locking is required or the oepration is sensitive to proper synchronization. In these cases, it can be helpful or important to log some information to help administrators if something were to act up. This is going to be true for the local broker. This change introduces `reviewboard.admin.server.is_nfs_path()` to help perform this check. This takes a path and checks to see if there's a known mount point that it may live in. This is a best-effort check and is only capable of checking Linux's `/proc/mounts`. On other sytsems (or if there is an issue accessing this), this will return `False`. The result is cached in an LRU cache to avoid repeated lookups for the same paths. In practice, this is going to be used only with very few hard-coded paths (such as a local queue path or parts of the data directory).	94b2234d58dcbbea33ed0b66c47b61eaf770d392

Diff:

Revision 2 (+418 -2)

Show changes

	reviewboard/admin/server.py
	reviewboard/admin/tests/test_server.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it! Fix it!

reviewboard/admin/server.py (Diff revision 2)
An issue was opened. Show all issues
```
Should be typed as Final[Pattern[str]]
```
reviewboard/admin/server.py (Diff revision 2)
An issue was opened. Show all issues
```
This might be better named as _NFS_FS_TYPES?
```

reviewboard/admin/server.py (Diff revision 2)

An issue was opened. Show all issues

Have you actually seen "efs" in the wild? I would expect EFS to show up as "nfs4" (covered by the "nfs" prefix check already).

chipx86

July 23, 2026, 4:50 p.m.

We use it on our servers, but it does end up translating to nfs4. It's efs in /etc/fstab (requires its own drivers), but translates to nfs4 in /proc/mounts. But I wouldn't have expected that?

david

July 23, 2026, 5:15 p.m.
```
That matches what I was seeing.
```