-
-
reviewboard/scmtools/clearcase.py (Diff revision 1) Where is filename variable defined? It is not a function arg, and it is not a class member?
Support for directory changes in reviewboard diffviewer
Review Request #1519 — Created April 20, 2010 and submitted
Information | |
---|---|
jan.koprowski | |
Review Board | |
1626 | |
Reviewers | |
reviewboard | |
This patch add support for ClearCase directory revisions. This is diff between "ls -1" command for each of them.
CK
DJ
-
-
reviewboard/scmtools/clearcase.py (Diff revision 1) This isn't necessary and will break if the user doesn't have an 'ls' command. Use os.walk instead.
Change Summary:
Change method to version using listdir from Python os module.
Diff: |
Revision 3 (+17 -1) |
---|
-
-
reviewboard/scmtools/clearcase.py (Diff revision 3) We may as well simplify this and call adjust_path once, and pass the result to the proper function.
-
reviewboard/scmtools/clearcase.py (Diff revision 3) This confuses me. We're already getting the '\n's from the join. Why are we appending a '\n' as well? That'll lead to a double '\n'.
-
-
-
-
reviewboard/scmtools/clearcase.py (Diff revision 4) Should remove the print statement. It can actually cause problems on some web server setups.
-
reviewboard/scmtools/clearcase.py (Diff revision 4) Is that what you really want? The last line won't have a trailing newline.