Summary

Isolate certificate storage between HTTPS handler tests.

Review Request #15186 — Created July 21, 2026 and updated July 21, 2026, 7:59 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-8.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

CertificateVerificationHTTPSHandlerTests built a fresh
CertificateManager per test, but every manager shares one on-disk storage
path. Certificates added by one test were therefore still present for the
next, and the tests only passed because of the order they happened to run in.
Running one on its own could fail against certificates it never added.

These tests now clear the certs directory before and after each test, matching
what BuildSSLContextFromSSLCertTests already does.

test_init_with_hostname no longer needs to add a client certificate it does
not care about, so that has been dropped.

Testing Done


Ran each test in the class on its own, and ran the class as a whole.
Ran unit tests for reviewboard.certs.

Commits

Summary	ID
Isolate certificate storage between HTTPS handler tests. `CertificateVerificationHTTPSHandlerTests` built a fresh `CertificateManager` per test, but every manager shares one on-disk storage path. Certificates added by one test were therefore still present for the next, and the tests only passed because of the order they happened to run in. Running one on its own could fail against certificates it never added. These tests now clear the certs directory before and after each test, matching what `BuildSSLContextFromSSLCertTests` already does. `test_init_with_hostname` no longer needs to add a client certificate it does not care about, so that has been dropped. Testing Done: - Ran each test in the class on its own, and ran the class as a whole. - Ran unit tests for `reviewboard.certs`.	vnlnokzlxoorpnpwvxrlqyxlsrokwqzy

Summary

Isolate certificate storage between HTTPS handler tests.

`CertificateVerificationHTTPSHandlerTests` built a fresh `CertificateManager` per test, but every manager shares one on-disk storage path. Certificates added by one test were therefore still present for the next, and the tests only passed because of the order they happened to run in. Running one on its own could fail against certificates it never added. These tests now clear the certs directory before and after each test, matching what `BuildSSLContextFromSSLCertTests` already does. `test_init_with_hostname` no longer needs to add a client certificate it does not care about, so that has been dropped. Testing Done: - Ran each test in the class on its own, and ran the class as a whole. - Ran unit tests for `reviewboard.certs`.

vnlnokzlxoorpnpwvxrlqyxlsrokwqzy

flake8 passed.

JSHint passed.