ClearCase directory diffs from post-review side

Review Request #1518 — Created April 20, 2010 and submitted

jan.koprowski
RBTools
1626
reviewboard
This patch add support for ClearCase directory revisions. This is diff between "ls -1" command for each of them.


JA
JA
chipx86
  1. 
      
  2. rbtools/postreview.py (Diff revision 2)
     
     
     
     
     
    This can be replaced with:
    
    content = [
        '%s\n' % s
        for s in sorted(os.listdir(filename))
    ]
    1. Fine :) I will replace it.
  3. rbtools/postreview.py (Diff revision 2)
     
     
    Why is the extra \n needed? I assume there's a reason, but can you add a comment briefly explaining it?
    1. My mistake. Error was caused by issue with 1644 where workaround implemented in lines 1124-1126 just made wrong.
  4. 
      
JA
JA
JA
Review request changed

Change Summary:

Fix print diff 

Diff:

Revision 5 (+16 -8)

Show changes

chipx86
  1. 
      
  2. rbtools/postreview.py (Diff revision 5)
     
     
    What's this?
    1. Very important thing. Python "print" add new line at end of string. This cause diff printed by post-review is malformed. Coma after print forbid add new line sign.
  3. 
      
david
  1. Looks good. Committed as raf99a53. Thanks!
  2. 
      
Loading...