Summary

ClearCase directory diffs from post-review side

Review Request #1518 — Created April 20, 2010 and submitted

Information

Owner

jan.koprowski

Repository

RBTools

Branch

Bugs

1626

Depends On

Reviewers

Groups

reviewboard

People

Description

This patch add support for ClearCase directory revisions. This is diff between "ls -1" command for each of them.

Testing Done

Change Summary:: Add bug information
Bugs:: 1626

Change Summary:

Change method to version using listdir from Python os module.

Diff:

Revision 2 (+14 -7)

Show changes

rbtools/postreview.py

rbtools/postreview.py (Diff revision 2)

This can be replaced with:

content = [
    '%s\n' % s
    for s in sorted(os.listdir(filename))
]

jan.koprowski

June 2, 2010, 12:47 a.m.
```
Fine :) I will replace it.
```

rbtools/postreview.py (Diff revision 2)

Why is the extra \n needed? I assume there's a reason, but can you add a comment briefly explaining it?

jan.koprowski

June 2, 2010, 12:46 a.m.

My mistake. Error was caused by issue with 1644 where workaround implemented in lines 1124-1126 just made wrong.

Change Summary:

fixed

Diff:

Revision 3 (+15 -7)

Show changes

rbtools/postreview.py

Change Summary:

Fixed typo

Diff:

Revision 4 (+15 -7)

Show changes

rbtools/postreview.py

Change Summary:

Fix print diff

Diff:

Revision 5 (+16 -8)

Show changes

rbtools/postreview.py

rbtools/postreview.py (Diff revision 5)

What's this?

jan.koprowski

June 27, 2010, 3:20 p.m.

Very important thing. Python "print" add new line at end of string. This cause diff printed by post-review is malformed. Coma after print forbid add new line sign.

Ship it!

Looks good. Committed as raf99a53. Thanks!