Summary

Fix diff path generation when running inside a setview.

Review Request #15148 — Created July 3, 2026 and updated July 7, 2026, 8:48 a.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

On linux, users can enter a ClearCase view either through the view root
(/view/<tag>/...) or with cleartool setview. In the setview case,
cleartool pwv -root returns an empty string, which we stored as the
root path of the view.

Every path in the generated diff (the diff headers, the DiffX
"path" fields, and the versionvault metadata) is computed with
os.path.relpath() against that root path. With an empty root path,
relpath() resolves against the current working directory instead,
producing paths like "../gui2/bin/clearcase/Xmakefile" that depend
entirely on where the user happened to run rbt.

The server can never resolve these, resulting in file-not-found errors
during diff validation. The same change would post fine for a user who
entered the view through /view/<tag>, which made the failures look
sporadic.

We now detect the empty result and use the filesystem root as the view
root. In a setview, VOBs appear directly under /, so this makes all
generated paths view-relative again, matching what a /view-based
workflow produces.

Testing Done


Added a unit test for get_local_path() in a setview context.
Ran unit tests.

Commits

Summary	ID
Fix diff path generation when running inside a setview. On linux, users can enter a ClearCase view either through the view root (/view/<tag>/...) or with `cleartool setview`. In the setview case, `cleartool pwv -root` returns an empty string, which we stored as the root path of the view. Every path in the generated diff (the diff headers, the DiffX "path" fields, and the versionvault metadata) is computed with `os.path.relpath()` against that root path. With an empty root path, `relpath()` resolves against the current working directory instead, producing paths like "../gui2/bin/clearcase/Xmakefile" that depend entirely on where the user happened to run rbt. The server can never resolve these, resulting in file-not-found errors during diff validation. The same change would post fine for a user who entered the view through /view/<tag>, which made the failures look sporadic. We now detect the empty result and use the filesystem root as the view root. In a setview, VOBs appear directly under /, so this makes all generated paths view-relative again, matching what a /view-based workflow produces. Testing Done: - Added a unit test for get_local_path() in a setview context. - Ran unit tests.	kvyqumtmwmvoootxkpvzskpmtnlkopxs

Summary

Fix diff path generation when running inside a setview.

On linux, users can enter a ClearCase view either through the view root (/view/<tag>/...) or with `cleartool setview`. In the setview case, `cleartool pwv -root` returns an empty string, which we stored as the root path of the view. Every path in the generated diff (the diff headers, the DiffX "path" fields, and the versionvault metadata) is computed with `os.path.relpath()` against that root path. With an empty root path, `relpath()` resolves against the current working directory instead, producing paths like "../gui2/bin/clearcase/Xmakefile" that depend entirely on where the user happened to run rbt. The server can never resolve these, resulting in file-not-found errors during diff validation. The same change would post fine for a user who entered the view through /view/<tag>, which made the failures look sporadic. We now detect the empty result and use the filesystem root as the view root. In a setview, VOBs appear directly under /, so this makes all generated paths view-relative again, matching what a /view-based workflow produces. Testing Done: - Added a unit test for get_local_path() in a setview context. - Ran unit tests.

kvyqumtmwmvoootxkpvzskpmtnlkopxs

Issues

Description	From	Last Updated
The code was already this way, but let's avoid setting root_path until we have a validated, normalized value. This new …	chipx86	July 7, 2026, 8:47 a.m.

flake8 passed.

JSHint passed.

rbtools/clients/clearcase.py (Diff revision 1)

The issue has been resolved. Show all issues

The code was already this way, but let's avoid setting root_path until we have a validated, normalized value.

This new block could also just be folded into the initial set as an or os.sep.

Commits:

	Summary	ID
	Fix diff path generation when running inside a setview. On linux, users can enter a ClearCase view either through the view root (/view/<tag>/...) or with `cleartool setview`. In the setview case, `cleartool pwv -root` returns an empty string, which we stored as the root path of the view. Every path in the generated diff (the diff headers, the DiffX "path" fields, and the versionvault metadata) is computed with `os.path.relpath()` against that root path. With an empty root path, `relpath()` resolves against the current working directory instead, producing paths like "../gui2/bin/clearcase/Xmakefile" that depend entirely on where the user happened to run rbt. The server can never resolve these, resulting in file-not-found errors during diff validation. The same change would post fine for a user who entered the view through /view/<tag>, which made the failures look sporadic. We now detect the empty result and use the filesystem root as the view root. In a setview, VOBs appear directly under /, so this makes all generated paths view-relative again, matching what a /view-based workflow produces. Testing Done: - Added a unit test for get_local_path() in a setview context. - Ran unit tests.	kvyqumtmwmvoootxkpvzskpmtnlkopxs
	Fix diff path generation when running inside a setview. On linux, users can enter a ClearCase view either through the view root (/view/<tag>/...) or with `cleartool setview`. In the setview case, `cleartool pwv -root` returns an empty string, which we stored as the root path of the view. Every path in the generated diff (the diff headers, the DiffX "path" fields, and the versionvault metadata) is computed with `os.path.relpath()` against that root path. With an empty root path, `relpath()` resolves against the current working directory instead, producing paths like "../gui2/bin/clearcase/Xmakefile" that depend entirely on where the user happened to run rbt. The server can never resolve these, resulting in file-not-found errors during diff validation. The same change would post fine for a user who entered the view through /view/<tag>, which made the failures look sporadic. We now detect the empty result and use the filesystem root as the view root. In a setview, VOBs appear directly under /, so this makes all generated paths view-relative again, matching what a /view-based workflow produces. Testing Done: - Added a unit test for get_local_path() in a setview context. - Ran unit tests.	kvyqumtmwmvoootxkpvzskpmtnlkopxs

Diff:

Revision 2 (+100 -4)

Show changes

	rbtools/clients/clearcase.py
	rbtools/clients/tests/test_clearcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.