Summary

Fix up all other imports, part 1.

Review Request #15143 — Created June 29, 2026 and updated July 7, 2026, 3:59 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-9.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Now that all our type hints have been updated to modern formats, this

change goes through and fixes up our import blocks. This includes removing

unused imports, moving things into TYPE_CHECKING blocks where

appropriate, and fixing sections/sorting. This change covers the

accounts, actions, admin, and attachments modules.

Testing Done

Ran unit tests.

Commits

Summary	ID
Fix up all other imports, part 1. Now that all our type hints have been updated to modern formats, this change goes through and fixes up our import blocks. This includes removing unused imports, moving things into `TYPE_CHECKING` blocks where appropriate, and fixing sections/sorting. This change covers the `accounts`, `actions`, `admin`, and `attachments` modules. Testing Done: Ran unit tests.	tklpnvvskpkqmwqmzuwnkwqzompypopp

Issues

Description	From	Last Updated
Missing a trailing comma.	chipx86	July 7, 2026, 3:56 p.m.
TextLexer should be before guess_lexer_for_filename.	chipx86	July 7, 2026, 3:56 p.m.

flake8 passed.

JSHint passed.

reviewboard/accounts/sso/backends/saml/sso_backend.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing a trailing comma.
```
reviewboard/attachments/mimetypes.py (Diff revision 1)
The issue has been resolved. Show all issues
```
TextLexer should be before guess_lexer_for_filename.
```

Commits:

	Summary	ID
	Fix up all other imports, part 1. Now that all our type hints have been updated to modern formats, this change goes through and fixes up our import blocks. This includes removing unused imports, moving things into `TYPE_CHECKING` blocks where appropriate, and fixing sections/sorting. This change covers the `accounts`, `actions`, `admin`, and `attachments` modules. Testing Done: Ran unit tests.	tklpnvvskpkqmwqmzuwnkwqzompypopp
	Fix up all other imports, part 1. Now that all our type hints have been updated to modern formats, this change goes through and fixes up our import blocks. This includes removing unused imports, moving things into `TYPE_CHECKING` blocks where appropriate, and fixing sections/sorting. This change covers the `accounts`, `actions`, `admin`, and `attachments` modules. Testing Done: Ran unit tests.	tklpnvvskpkqmwqmzuwnkwqzompypopp

Diff:

Revision 2 (+246 -178)

Show changes

	reviewboard/accounts/actions.py
	reviewboard/accounts/managers.py
	reviewboard/accounts/models.py
	reviewboard/accounts/urls.py
	reviewboard/accounts/user_details.py
	reviewboard/accounts/views.py
	reviewboard/accounts/backends/ad.py
	reviewboard/accounts/backends/nis.py
	42 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.