Summary

Add the initial "Connect a service" wizard flow.

Review Request #15140 — Created June 26, 2026 and updated July 17, 2026, 11:05 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-9.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

On the backend, this adds a ConnectServiceView that serves the
per-service connect fragment (GET) and processes the auth form (POST),
returning JSON with either a redirect on success or the re-rendered form
with errors. Authorization, two-factor, and certificate errors are
caught and surfaced inline, and unexpected errors are logged.

BaseHostingService now has overridable methods so services can customize
or replace the connect UI.

The wizard view also includes back-navigation and deep-link hooks
(initialConnectURL / data-connect-page) staged for the upcoming
GitHub App connection flow.

Testing Done


Ran unit tests.
Used the wizard to connect new hosting service accounts, exercising

  the success case as well as form errors.

Commits

Summary	ID
Add the initial "Connect a service" wizard flow. This adds the first step of the new "Connect a service" flow on the Connected Services admin page. Clicking "Connect a service" now opens a wizard dialog with a searchable, sectioned list of available hosting services ("Popular", "Source Hosting", "Issue Tracking"). Choosing a service loads its connect UI as a server-rendered fragment and submits the authentication form over AJAX, creating the `HostingServiceAccount`. On the backend, this adds a `ConnectServiceView` that serves the per-service connect fragment (GET) and processes the auth form (POST), returning JSON with either a redirect on success or the re-rendered form with errors. Authorization, two-factor, and certificate errors are caught and surfaced inline, and unexpected errors are logged. BaseHostingService now has overridable methods so services can customize or replace the connect UI. The wizard view also includes back-navigation and deep-link hooks (`initialConnectURL` / `data-connect-page`) staged for the upcoming GitHub App connection flow. Testing Done: - Ran unit tests. - Used the wizard to connect new hosting service accounts, exercising the success case as well as form errors.	ouuqozrxlzmxtvzmuqnpryzotlzyrzkv

Summary

Add the initial "Connect a service" wizard flow.

This adds the first step of the new "Connect a service" flow on the Connected Services admin page. Clicking "Connect a service" now opens a wizard dialog with a searchable, sectioned list of available hosting services ("Popular", "Source Hosting", "Issue Tracking"). Choosing a service loads its connect UI as a server-rendered fragment and submits the authentication form over AJAX, creating the `HostingServiceAccount`. On the backend, this adds a `ConnectServiceView` that serves the per-service connect fragment (GET) and processes the auth form (POST), returning JSON with either a redirect on success or the re-rendered form with errors. Authorization, two-factor, and certificate errors are caught and surfaced inline, and unexpected errors are logged. BaseHostingService now has overridable methods so services can customize or replace the connect UI. The wizard view also includes back-navigation and deep-link hooks (`initialConnectURL` / `data-connect-page`) staged for the upcoming GitHub App connection flow. Testing Done: - Ran unit tests. - Used the wizard to connect new hosting service accounts, exercising the success case as well as form errors.

ouuqozrxlzmxtvzmuqnpryzotlzyrzkv

Files

Issues

Description	From	Last Updated
continuation line over-indented for visual indent Column: 54 Error code: E127	reviewbot	June 26, 2026, 12:05 p.m.
This and the test case needs a Version Added.	maubin	July 17, 2026, 10:52 a.m.
Can you put the arguments each on their own line.	maubin	July 17, 2026, 10:53 a.m.
Can we put each entry on its own line.	maubin	July 17, 2026, 10:53 a.m.
We don't actually pass the local_site in any of the calls. We could get rid of this arg and instead …	maubin	July 17, 2026, 11:03 a.m.
This is missing the outer <div class="ink-c-dialog rb-c-connect-wizard">.	maubin	July 17, 2026, 10:55 a.m.
'reviewboard.site.models.LocalSite' imported but unused Column: 5 Error code: F401	reviewbot	July 17, 2026, 11:05 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/tests/test_connect_service_view.py (Diff revision 1)
The issue has been dropped. Show all issues
```
continuation line over-indented for visual indent

Column: 54
Error code: E127
```

Commits:

	Summary	ID
	Add the initial "Connect a service" wizard flow. This adds the first step of the new "Connect a service" flow on the Connected Services admin page. Clicking "Connect a service" now opens a wizard dialog with a searchable, sectioned list of available hosting services ("Popular", "Source Hosting", "Issue Tracking"). Choosing a service loads its connect UI as a server-rendered fragment and submits the authentication form over AJAX, creating the `HostingServiceAccount`. On the backend, this adds a `ConnectServiceView` that serves the per-service connect fragment (GET) and processes the auth form (POST), returning JSON with either a redirect on success or the re-rendered form with errors. Authorization, two-factor, and certificate errors are caught and surfaced inline, and unexpected errors are logged. BaseHostingService now has overridable methods so services can customize or replace the connect UI. The wizard view also includes back-navigation and deep-link hooks (`initialConnectURL` / `data-connect-page`) staged for the upcoming GitHub App connection flow. Testing Done: - Ran unit tests. - Used the wizard to connect new hosting service accounts, exercising the success case as well as form errors.	ouuqozrxlzmxtvzmuqnpryzotlzyrzkv
	Add the initial "Connect a service" wizard flow. This adds the first step of the new "Connect a service" flow on the Connected Services admin page. Clicking "Connect a service" now opens a wizard dialog with a searchable, sectioned list of available hosting services ("Popular", "Source Hosting", "Issue Tracking"). Choosing a service loads its connect UI as a server-rendered fragment and submits the authentication form over AJAX, creating the `HostingServiceAccount`. On the backend, this adds a `ConnectServiceView` that serves the per-service connect fragment (GET) and processes the auth form (POST), returning JSON with either a redirect on success or the re-rendered form with errors. Authorization, two-factor, and certificate errors are caught and surfaced inline, and unexpected errors are logged. BaseHostingService now has overridable methods so services can customize or replace the connect UI. The wizard view also includes back-navigation and deep-link hooks (`initialConnectURL` / `data-connect-page`) staged for the upcoming GitHub App connection flow. Testing Done: - Ran unit tests. - Used the wizard to connect new hosting service accounts, exercising the success case as well as form errors.	ouuqozrxlzmxtvzmuqnpryzotlzyrzkv

Diff:

Revision 2 (+3304 -18)

Show changes

	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/admin/tests/test_connect_service_view.py
	reviewboard/hostingsvcs/base/hosting_service.py
	reviewboard/static/rb/css/pages/admin/connected-services.less
	reviewboard/static/rb/js/admin/index.ts
	reviewboard/static/rb/js/admin/views/connectServiceWizardView.ts
	reviewboard/static/rb/js/admin/views/tests/connectServiceWizardViewTests.ts
	3 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/admin/tests/test_connect_service_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This and the test case needs a Version Added.
```
reviewboard/admin/tests/test_connect_service_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can you put the arguments each on their own line.
```
reviewboard/admin/views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can we put each entry on its own line.
```

reviewboard/hostingsvcs/base/hosting_service.py (Diff revision 2)

The issue has been resolved. Show all issues

We don't actually pass the local_site in any of the calls. We could get rid of this arg and instead pass request.local_site to the auth form.

reviewboard/static/rb/css/pages/admin/connected-services.less (Diff revision 2)

The issue has been resolved. Show all issues

This is missing the outer <div class="ink-c-dialog rb-c-connect-wizard">.

Commits:

	Summary	ID
	Add the initial "Connect a service" wizard flow. This adds the first step of the new "Connect a service" flow on the Connected Services admin page. Clicking "Connect a service" now opens a wizard dialog with a searchable, sectioned list of available hosting services ("Popular", "Source Hosting", "Issue Tracking"). Choosing a service loads its connect UI as a server-rendered fragment and submits the authentication form over AJAX, creating the `HostingServiceAccount`. On the backend, this adds a `ConnectServiceView` that serves the per-service connect fragment (GET) and processes the auth form (POST), returning JSON with either a redirect on success or the re-rendered form with errors. Authorization, two-factor, and certificate errors are caught and surfaced inline, and unexpected errors are logged. BaseHostingService now has overridable methods so services can customize or replace the connect UI. The wizard view also includes back-navigation and deep-link hooks (`initialConnectURL` / `data-connect-page`) staged for the upcoming GitHub App connection flow. Testing Done: - Ran unit tests. - Used the wizard to connect new hosting service accounts, exercising the success case as well as form errors.	ouuqozrxlzmxtvzmuqnpryzotlzyrzkv
	Add the initial "Connect a service" wizard flow. This adds the first step of the new "Connect a service" flow on the Connected Services admin page. Clicking "Connect a service" now opens a wizard dialog with a searchable, sectioned list of available hosting services ("Popular", "Source Hosting", "Issue Tracking"). Choosing a service loads its connect UI as a server-rendered fragment and submits the authentication form over AJAX, creating the `HostingServiceAccount`. On the backend, this adds a `ConnectServiceView` that serves the per-service connect fragment (GET) and processes the auth form (POST), returning JSON with either a redirect on success or the re-rendered form with errors. Authorization, two-factor, and certificate errors are caught and surfaced inline, and unexpected errors are logged. BaseHostingService now has overridable methods so services can customize or replace the connect UI. The wizard view also includes back-navigation and deep-link hooks (`initialConnectURL` / `data-connect-page`) staged for the upcoming GitHub App connection flow. Testing Done: - Ran unit tests. - Used the wizard to connect new hosting service accounts, exercising the success case as well as form errors.	ouuqozrxlzmxtvzmuqnpryzotlzyrzkv

Diff:

Revision 3 (+3348 -18)

Show changes

	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/admin/tests/test_connect_service_view.py
	reviewboard/hostingsvcs/base/hosting_service.py
	reviewboard/static/rb/css/pages/admin/connected-services.less
	reviewboard/static/rb/js/admin/index.ts
	reviewboard/static/rb/js/admin/views/connectServiceWizardView.ts
	reviewboard/static/rb/js/admin/views/tests/connectServiceWizardViewTests.ts
	3 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/base/hosting_service.py (Diff revision 3)
The issue has been dropped. Show all issues
```
'reviewboard.site.models.LocalSite' imported but unused

Column: 5
Error code: F401
```

Commits:

	Summary	ID
	Add the initial "Connect a service" wizard flow. This adds the first step of the new "Connect a service" flow on the Connected Services admin page. Clicking "Connect a service" now opens a wizard dialog with a searchable, sectioned list of available hosting services ("Popular", "Source Hosting", "Issue Tracking"). Choosing a service loads its connect UI as a server-rendered fragment and submits the authentication form over AJAX, creating the `HostingServiceAccount`. On the backend, this adds a `ConnectServiceView` that serves the per-service connect fragment (GET) and processes the auth form (POST), returning JSON with either a redirect on success or the re-rendered form with errors. Authorization, two-factor, and certificate errors are caught and surfaced inline, and unexpected errors are logged. BaseHostingService now has overridable methods so services can customize or replace the connect UI. The wizard view also includes back-navigation and deep-link hooks (`initialConnectURL` / `data-connect-page`) staged for the upcoming GitHub App connection flow. Testing Done: - Ran unit tests. - Used the wizard to connect new hosting service accounts, exercising the success case as well as form errors.	ouuqozrxlzmxtvzmuqnpryzotlzyrzkv
	Add the initial "Connect a service" wizard flow. This adds the first step of the new "Connect a service" flow on the Connected Services admin page. Clicking "Connect a service" now opens a wizard dialog with a searchable, sectioned list of available hosting services ("Popular", "Source Hosting", "Issue Tracking"). Choosing a service loads its connect UI as a server-rendered fragment and submits the authentication form over AJAX, creating the `HostingServiceAccount`. On the backend, this adds a `ConnectServiceView` that serves the per-service connect fragment (GET) and processes the auth form (POST), returning JSON with either a redirect on success or the re-rendered form with errors. Authorization, two-factor, and certificate errors are caught and surfaced inline, and unexpected errors are logged. BaseHostingService now has overridable methods so services can customize or replace the connect UI. The wizard view also includes back-navigation and deep-link hooks (`initialConnectURL` / `data-connect-page`) staged for the upcoming GitHub App connection flow. Testing Done: - Ran unit tests. - Used the wizard to connect new hosting service accounts, exercising the success case as well as form errors.	ouuqozrxlzmxtvzmuqnpryzotlzyrzkv

Diff:

Revision 4 (+3346 -18)

Show changes

	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/admin/tests/test_connect_service_view.py
	reviewboard/hostingsvcs/base/hosting_service.py
	reviewboard/static/rb/css/pages/admin/connected-services.less
	reviewboard/static/rb/js/admin/index.ts
	reviewboard/static/rb/js/admin/views/connectServiceWizardView.ts
	reviewboard/static/rb/js/admin/views/tests/connectServiceWizardViewTests.ts
	3 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.