Summary

Fix Perforce authentication and errors on 2026.1.

Review Request #15133 — Created June 23, 2026 and submitted July 10, 2026, 2:07 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-8.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This requires some changes on our end. Specifically, we now need to
ensure we do an explicit login when we connect (and after we've verified
we've successfully connected), as the p4.password we set will no
longer apply otherwise.

The list of authentication error strings was updated to handle "Password
invalid", which may have already existed but was not being handled by
our code.

Authentication is now only performed once a connection is established.
This avoids an attempt at a login when we've hit an outage or cert error
(which would trigger a "not connected" P4 error).

The unit test database has been updated for p4d 2026.1, and as part of
this, each user had to be given a password. These are guest12345,
samwise12345, and david12345 (for those respective users). The unit
tests have been updated to set these credentials for the connection
where appropriate.

Testing Done

Unit tests pass with p4d 2026.1, p4 2026.1, and p4python 2026.1.

Tested the code changes with the previous 2021.2 database and matching
versions of p4d, p4, and p4python. Unit tests passed.

Manually tested review requests and diffs with a local P4 server, using
both the 2021.2 and 2026.1 versions, without ticket auth (using the new
password login flow). These failed on 2026.1 before, but worked with the
new changes.

Commits

Summary	ID
Fix Perforce authentication and errors on 2026.1. Perforce 2026.1 was a big security-by-default release, which focused on an increased default security level for authentication, no password-less access, no set-password-on-first-connect behavior, and other changes. This requires some changes on our end. Specifically, we now need to ensure we do an explicit login when we connect (and after we've verified we've successfully connected), as the `p4.password` we set will no longer apply otherwise. The list of authentication error strings was updated to handle "Password invalid", which may have already existed but was not being handled by our code. Authentication is now only performed once a connection is established. This avoids an attempt at a login when we've hit an outage or cert error (which would trigger a "not connected" P4 error). The unit test database has been updated for p4d 2026.1, and as part of this, each user had to be given a password. These are `guest12345`, `samwise12345`, and `david12345` (for those respective users). The unit tests have been updated to set these credentials for the connection where appropriate.	d2abc3be200eb6d14d1f378c0ea208dc9eaed369

Summary

Fix Perforce authentication and errors on 2026.1.

Perforce 2026.1 was a big security-by-default release, which focused on an increased default security level for authentication, no password-less access, no set-password-on-first-connect behavior, and other changes. This requires some changes on our end. Specifically, we now need to ensure we do an explicit login when we connect (and after we've verified we've successfully connected), as the `p4.password` we set will no longer apply otherwise. The list of authentication error strings was updated to handle "Password invalid", which may have already existed but was not being handled by our code. Authentication is now only performed once a connection is established. This avoids an attempt at a login when we've hit an outage or cert error (which would trigger a "not connected" P4 error). The unit test database has been updated for p4d 2026.1, and as part of this, each user had to be given a password. These are `guest12345`, `samwise12345`, and `david12345` (for those respective users). The unit tests have been updated to set these credentials for the connection where appropriate.

d2abc3be200eb6d14d1f378c0ea208dc9eaed369

Issues

Description	From	Last Updated
Can we add tests for the _AUTH_ERROR_RE strings resulting in AuthenticationError?	david	June 24, 2026, 2:43 p.m.
Can we put this on release-7.x? We'll want to be able to run tests there.	david	June 24, 2026, 2:43 p.m.
Can we call self.login() here so we get the logging that it does?	david	June 24, 2026, 1:30 p.m.
I know some versions of p4python have added prefixes to errors. Can we use .search(error) instead of .match()?	david	June 24, 2026, 12:59 p.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Can we add tests for the _AUTH_ERROR_RE strings resulting in AuthenticationError?

chipx86

June 24, 2026, 1:30 p.m.
```
I'll try to work something up.
```

chipx86

June 24, 2026, 2:36 p.m.

I can do a couple, but there are some auth errors that require very specialized setups. I can do it but it'll add a day or two to this, and that's a bad use of my time, so I'm punting on those.

The issue has been dropped. Show all issues

Can we put this on release-7.x? We'll want to be able to run tests there.

chipx86

June 24, 2026, 1:30 p.m.
```
Yeah, I'll backport after.
```

reviewboard/scmtools/perforce.py (Diff revision 1)

The issue has been dropped. Show all issues

Can we call self.login() here so we get the logging that it does?

chipx86

June 24, 2026, 1:30 p.m.

It'll info-log on every single P4 operation, which is very spammy and not necessary. It's really there for ticket refreshes so it's only done periodically. Should probably rename it or fold it into check_refresh_ticket() (but I don't want to grow the scope of this change).

reviewboard/scmtools/perforce.py (Diff revision 1)

The issue has been resolved. Show all issues

I know some versions of p4python have added prefixes to errors. Can we use .search(error) instead of .match()?

Change Summary:


Added more authentication errors, and tests for some of them (a few would involve too much work to do right now).
Added a missing password for the stunnel tests.

Commits:

	Summary	ID
	Fix Perforce authentication and errors on 2026.1. Perforce 2026.1 was a big security-by-default release, which focused on an increased default security level for authentication, no password-less access, no set-password-on-first-connect behavior, and other changes. This requires some changes on our end. Specifically, we now need to ensure we do an explicit login when we connect (and after we've verified we've successfully connected), as the `p4.password` we set will no longer apply otherwise. The list of authentication error strings was updated to handle "Password invalid", which may have already existed but was not being handled by our code. Authentication is now only performed once a connection is established. This avoids an attempt at a login when we've hit an outage or cert error (which would trigger a "not connected" P4 error). The unit test database has been updated for p4d 2026.1, and as part of this, each user had to be given a password. These are `guest12345`, `samwise12345`, and `david12345` (for those respective users). The unit tests have been updated to set these credentials for the connection where appropriate.	0c835eadcee5a2476d285cceccf640d619f8eddd
	Fix Perforce authentication and errors on 2026.1. Perforce 2026.1 was a big security-by-default release, which focused on an increased default security level for authentication, no password-less access, no set-password-on-first-connect behavior, and other changes. This requires some changes on our end. Specifically, we now need to ensure we do an explicit login when we connect (and after we've verified we've successfully connected), as the `p4.password` we set will no longer apply otherwise. The list of authentication error strings was updated to handle "Password invalid", which may have already existed but was not being handled by our code. Authentication is now only performed once a connection is established. This avoids an attempt at a login when we've hit an outage or cert error (which would trigger a "not connected" P4 error). The unit test database has been updated for p4d 2026.1, and as part of this, each user had to be given a password. These are `guest12345`, `samwise12345`, and `david12345` (for those respective users). The unit tests have been updated to set these credentials for the connection where appropriate.	d2abc3be200eb6d14d1f378c0ea208dc9eaed369

Diff:

Revision 2 (+194 -58)

Show changes

	reviewboard/scmtools/perforce.py
	reviewboard/scmtools/testdata/p4_repo/db.config
	reviewboard/scmtools/testdata/p4_repo/db.configh
	reviewboard/scmtools/testdata/p4_repo/db.counters
	reviewboard/scmtools/testdata/p4_repo/db.depot
	reviewboard/scmtools/testdata/p4_repo/db.domain
	reviewboard/scmtools/testdata/p4_repo/db.monitor
	reviewboard/scmtools/testdata/p4_repo/db.protect
	6 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-8.x (3976499)