Summary

Fix some bugs in authentication to Forgejo servers.

Review Request #15131 — Created June 23, 2026 and submitted June 26, 2026, 8:18 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-8.x

Bugs

5069

Depends On

Reviewers

Groups

reviewboard

People

Description

The Forgejo authentication path had a few issues, which this change
fixes:

get_http_credentials was returning a header key as per the base
HostingServiceClient docstring, but this should have been headers.
I've fixed both the bug in the Forgejo client as well as the incorrect
docstring.
Some API errors don't include the url field, which was marked as
required in the Pydantic schema.
Re-authentication ("Edit Credentials") was broken because it would
still try to use the saved API key, resulting in an error about not
having the "user:write" scope.

Due to the fix for the re-authentication issue, I discovered that the
HostingServiceTestCase.create_hosting_account method was aliasing
default_account_data instead of copying it, which allowed tests to
interfere with each other.

Testing Done


Authenticated to a new Forgejo server with both 2FA required and not.
Re-authenticated and saw that it correctly issued a new API token

  instead of getting a scope error.
Ran unit tests.

Commits

Summary	ID
Fix some bugs in authentication to Forgejo servers. The Forgejo authentication path had a few issues, which this change fixes: - `get_http_credentials` was returning a `header` key as per the base `HostingServiceClient` docstring, but this should have been `headers`. I've fixed both the bug in the Forgejo client as well as the incorrect docstring. - Some API errors don't include the `url` field, which was marked as required in the Pydantic schema. - Re-authentication ("Edit Credentials") was broken because it would still try to use the saved API key, resulting in an error about not having the "user:write" scope. Due to the fix for the re-authentication issue, I discovered that the `HostingServiceTestCase.create_hosting_account` method was aliasing `default_account_data` instead of copying it, which allowed tests to interfere with each other. Testing Done: - Authenticated to a new Forgejo server with both 2FA required and not. - Re-authenticated and saw that it correctly issued a new API token instead of getting a scope error. - Ran unit tests. Fixes bug 5069.	ouwsnxkukrtlqlumwozrotolrwqpqmxo

Summary

Fix some bugs in authentication to Forgejo servers.

The Forgejo authentication path had a few issues, which this change fixes: - `get_http_credentials` was returning a `header` key as per the base `HostingServiceClient` docstring, but this should have been `headers`. I've fixed both the bug in the Forgejo client as well as the incorrect docstring. - Some API errors don't include the `url` field, which was marked as required in the Pydantic schema. - Re-authentication ("Edit Credentials") was broken because it would still try to use the saved API key, resulting in an error about not having the "user:write" scope. Due to the fix for the re-authentication issue, I discovered that the `HostingServiceTestCase.create_hosting_account` method was aliasing `default_account_data` instead of copying it, which allowed tests to interfere with each other. Testing Done: - Authenticated to a new Forgejo server with both 2FA required and not. - Re-authenticated and saw that it correctly issued a new API token instead of getting a scope error. - Ran unit tests. Fixes bug 5069.

ouwsnxkukrtlqlumwozrotolrwqpqmxo

Issues

Description	From	Last Updated
do not use bare 'except' Column: 9 Error code: E722	reviewbot	June 23, 2026, 12:17 p.m.
Missing a period.	maubin	June 26, 2026, 8:18 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 1)
The issue has been dropped. Show all issues
```
do not use bare 'except'

Column: 9
Error code: E722
```

Commits:

	Summary	ID
	Fix some bugs in authentication to Forgejo servers. The Forgejo authentication path had a few issues, which this change fixes: - `get_http_credentials` was returning a `header` key as per the base `HostingServiceClient` docstring, but this should have been `headers`. I've fixed both the bug in the Forgejo client as well as the incorrect docstring. - Some API errors don't include the `url` field, which was marked as required in the Pydantic schema. - Re-authentication ("Edit Credentials") was broken because it would still try to use the saved API key, resulting in an error about not having the "user:write" scope. Due to the fix for the re-authentication issue, I discovered that the `HostingServiceTestCase.create_hosting_account` method was aliasing `default_account_data` instead of copying it, which allowed tests to interfere with each other. Testing Done: - Authenticated to a new Forgejo server with both 2FA required and not. - Re-authenticated and saw that it correctly issued a new API token instead of getting a scope error. - Ran unit tests. Fixes bug 5069.	ouwsnxkukrtlqlumwozrotolrwqpqmxo
	Fix some bugs in authentication to Forgejo servers. The Forgejo authentication path had a few issues, which this change fixes: - `get_http_credentials` was returning a `header` key as per the base `HostingServiceClient` docstring, but this should have been `headers`. I've fixed both the bug in the Forgejo client as well as the incorrect docstring. - Some API errors don't include the `url` field, which was marked as required in the Pydantic schema. - Re-authentication ("Edit Credentials") was broken because it would still try to use the saved API key, resulting in an error about not having the "user:write" scope. Due to the fix for the re-authentication issue, I discovered that the `HostingServiceTestCase.create_hosting_account` method was aliasing `default_account_data` instead of copying it, which allowed tests to interfere with each other. Testing Done: - Authenticated to a new Forgejo server with both 2FA required and not. - Re-authenticated and saw that it correctly issued a new API token instead of getting a scope error. - Ran unit tests. Fixes bug 5069.	ouwsnxkukrtlqlumwozrotolrwqpqmxo

Diff:

Revision 2 (+48 -14)

Show changes

	reviewboard/hostingsvcs/base/client.py
	reviewboard/hostingsvcs/forgejo/api.py
	reviewboard/hostingsvcs/forgejo/client.py
	reviewboard/hostingsvcs/testing/testcases.py
	reviewboard/hostingsvcs/tests/test_forgejo.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/hostingsvcs/forgejo/client.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing a period.
```

Status:: Completed
Change Summary:: Pushed to release-8.x (1b4678b)