Summary

Modernize github implementation and use Pydantic for parsing.

Review Request #15122 — Created June 12, 2026 and updated June 12, 2026, 11:21 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-9.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change updates our github client implementation to use Pydantic for
parsing API payloads, and fixes up type hints and docstrings throughout.

While working in the paginated resources, I realized that the start
and per_page parameters weren't getting plumbed through at all, so
I've fixed that as well.

Testing Done

Ran unit tests.

Commits

Summary	ID
Modernize github implementation and use Pydantic for parsing. This change updates our github client implementation to use Pydantic for parsing API payloads, and fixes up type hints and docstrings throughout. While working in the paginated resources, I realized that the way the page parameters were plumbed for the GitHubAPIPaginator wasn't actually working, and that given that GitHub API resources don't use a consistent name for the start parameter, I've baked the start and per_page values into the initial URL parameters instead of relying on the `request_kwargs` member. Testing Done: Ran unit tests.	myylkmlorkqwkztrmunzoxxvoszokpqp

Summary

Modernize github implementation and use Pydantic for parsing.

This change updates our github client implementation to use Pydantic for parsing API payloads, and fixes up type hints and docstrings throughout. While working in the paginated resources, I realized that the way the page parameters were plumbed for the GitHubAPIPaginator wasn't actually working, and that given that GitHub API resources don't use a consistent name for the start parameter, I've baked the start and per_page values into the initial URL parameters instead of relying on the `request_kwargs` member. Testing Done: Ran unit tests.

myylkmlorkqwkztrmunzoxxvoszokpqp

Issues

Description	From	Last Updated
closing bracket does not match indentation of opening bracket's line Column: 9 Error code: E123	reviewbot	June 12, 2026, 11:22 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/github/service.py (Diff revision 1)

The issue has been dropped. Show all issues

closing bracket does not match indentation of opening bracket's line

Column: 9
Error code: E123

Commits:

	Summary	ID
	Modernize github implementation and use Pydantic for parsing. This change updates our github client implementation to use Pydantic for parsing API payloads, and fixes up type hints and docstrings throughout. While working in the paginated resources, I realized that the way the page parameters were plumbed for the GitHubAPIPaginator wasn't actually working, and that given that GitHub API resources don't use a consistent name for the start parameter, I've baked the start and per_page values into the initial URL parameters instead of relying on the `request_kwargs` member. Testing Done: Ran unit tests.	myylkmlorkqwkztrmunzoxxvoszokpqp
	Modernize github implementation and use Pydantic for parsing. This change updates our github client implementation to use Pydantic for parsing API payloads, and fixes up type hints and docstrings throughout. While working in the paginated resources, I realized that the way the page parameters were plumbed for the GitHubAPIPaginator wasn't actually working, and that given that GitHub API resources don't use a consistent name for the start parameter, I've baked the start and per_page values into the initial URL parameters instead of relying on the `request_kwargs` member. Testing Done: Ran unit tests.	myylkmlorkqwkztrmunzoxxvoszokpqp

Diff:

Revision 2 (+2852 -1048)

Show changes

	reviewboard/hostingsvcs/base/paginator.py
	reviewboard/hostingsvcs/github/api.py
	reviewboard/hostingsvcs/github/client.py
	reviewboard/hostingsvcs/github/forms.py
	reviewboard/hostingsvcs/github/service.py
	reviewboard/hostingsvcs/github/views.py
	reviewboard/hostingsvcs/tests/test_github.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.