Summary

Update typing: Optional[...] part 2

Review Request #15113 — Created June 12, 2026 and updated June 12, 2026, 10:30 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-9.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change updates legacy type hints that use the old Optional[...] form
to be (... | None) instead. This change covers the codesafety, datagrids,
and diffviewer apps, along with some internal stuff in contrib and
cmdline.

Because I want to keep this tightly focused and easy to review, this
does not make any changes to other legacy type hints, documentation,
etc., even within the changed lines. Those will come in future changes.

Testing Done

Ran unit tests.

Commits

Summary	ID
Update typing: Optional[...] part 2 This change updates legacy type hints that use the old `Optional[...]` form to be `(... \| None)` instead. This change covers the `codesafety`, `datagrids`, and `diffviewer` apps, along with some internal stuff in `contrib` and `cmdline`. Because I want to keep this tightly focused and easy to review, this does not make any changes to other legacy type hints, documentation, etc., even within the changed lines. Those will come in future changes. Testing Done: Ran unit tests.	nrpqxqvnwyzxkpypunpzyztmtkslyokl

Summary

Update typing: Optional[...] part 2

This change updates legacy type hints that use the old `Optional[...]` form to be `(... | None)` instead. This change covers the `codesafety`, `datagrids`, and `diffviewer` apps, along with some internal stuff in `contrib` and `cmdline`. Because I want to keep this tightly focused and easy to review, this does not make any changes to other legacy type hints, documentation, etc., even within the changed lines. Those will come in future changes. Testing Done: Ran unit tests.

nrpqxqvnwyzxkpypunpzyztmtkslyokl

Issues

Description	From	Last Updated
'typing.Union' imported but unused Column: 1 Error code: F401	reviewbot	June 12, 2026, 10:31 a.m.
'typing.Union' imported but unused Column: 1 Error code: F401	reviewbot	June 12, 2026, 11:12 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/diffviewer/filediff_creator.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'typing.Union' imported but unused

Column: 1
Error code: F401
```
reviewboard/diffviewer/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'typing.Union' imported but unused

Column: 1
Error code: F401
```