Summary

Add tox for testing, update setuptools deps, and fix <= 3.9 testing.

Review Request #15109 — Created June 10, 2026 and updated July 11, 2026, 3:38 a.m.

Information

Owner

chipx86

Repository

buildthings

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

To improve testing going forward, this change introduces support for
tox. It's set up to test with 3.9 through 3.14 (but not 3.8, as the
modern license files in our pyproject.toml aren't compatible with the
latest setuptools for 3.8).

Some test-specific issues were caught with tthis on 3.9 and older. We
were asserting on Distribution.name, which wasn't available. This
check isn't really necessary, and has been removed.

To ensure consistency with testing, setuptools has also been updated
to the latest versions available.

Testing Done

Ran tox. All tests pass.

Commits

Summary	ID
Add tox for testing, update setuptools deps, and fix <= 3.9 testing. To improve testing going forward, this change introduces support for `tox`. It's set up to test with 3.9 through 3.14 (but not 3.8, as the modern license files in our `pyproject.toml` aren't compatible with the latest `setuptools` for 3.8). Some test-specific issues were caught with tthis on 3.9 and older. We were asserting on `Distribution.name`, which wasn't available. This check isn't really necessary, and has been removed. To ensure consistency with testing, `setuptools` has also been updated to the latest versions available.	d051266bdc93bcbedd326d941db97c715699afb2

Summary

Add tox for testing, update setuptools deps, and fix <= 3.9 testing.

To improve testing going forward, this change introduces support for `tox`. It's set up to test with 3.9 through 3.14 (but not 3.8, as the modern license files in our `pyproject.toml` aren't compatible with the latest `setuptools` for 3.8). Some test-specific issues were caught with tthis on 3.9 and older. We were asserting on `Distribution.name`, which wasn't available. This check isn't really necessary, and has been removed. To ensure consistency with testing, `setuptools` has also been updated to the latest versions available.

d051266bdc93bcbedd326d941db97c715699afb2

Issues

Description	From	Last Updated
Interdiff seems empty?	david	July 11, 2026, 3:38 a.m.
skip_dist isn't a thing in the tox documentation. I think maybe you were thinking of skipsdist, but we probably shouldn't …	david	July 10, 2026, 8:50 a.m.
The preferred way to do this is now package = "editable"	david	July 10, 2026, 8:50 a.m.

flake8 passed.

JSHint passed.

tox.toml (Diff revision 1)

The issue has been resolved. Show all issues

skip_dist isn't a thing in the tox documentation. I think maybe you were thinking of skipsdist, but we probably shouldn't be using that.

tox.toml (Diff revision 1)
The issue has been resolved. Show all issues
```
The preferred way to do this is now package = "editable"
```

Change Summary:

Updated tox.toml to use the correct options.

Commits:

	Summary	ID
	Add tox for testing, update setuptools deps, and fix <= 3.9 testing. To improve testing going forward, this change introduces support for `tox`. It's set up to test with 3.9 through 3.14 (but not 3.8, as the modern license files in our `pyproject.toml` aren't compatible with the latest `setuptools` for 3.8). Some test-specific issues were caught with tthis on 3.9 and older. We were asserting on `Distribution.name`, which wasn't available. This check isn't really necessary, and has been removed. To ensure consistency with testing, `setuptools` has also been updated to the latest versions available.	4f4677266401fea7be856b490c5cbee0e4fbd96d
	Add tox for testing, update setuptools deps, and fix <= 3.9 testing. To improve testing going forward, this change introduces support for `tox`. It's set up to test with 3.9 through 3.14 (but not 3.8, as the modern license files in our `pyproject.toml` aren't compatible with the latest `setuptools` for 3.8). Some test-specific issues were caught with tthis on 3.9 and older. We were asserting on `Distribution.name`, which wasn't available. This check isn't really necessary, and has been removed. To ensure consistency with testing, `setuptools` has also been updated to the latest versions available.	d051266bdc93bcbedd326d941db97c715699afb2

Diff:

Revision 2 (+58 -12)

Show changes

	pyproject.toml
	tox.toml
	buildthings/tests/utils.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Fix it!

An issue was opened. Show all issues
```
Interdiff seems empty?
```