Summary

Add support for always-enabled extensions.

Review Request #15106 — Created June 7, 2026 and updated June 11, 2026, 7:38 a.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

The extension manager can now be given a list of extensions that must

always be enabled. These act like enabled-by-default extensions, except

that they cannot be disabled through disable_extension() or the UI,

and will be considered enabled every time the extension manager loads.
This and the enabled-by-default extensions can both be set in

settings, or can now be set as attributes on the extension manager,

giving implementations a central, non-settings-based place to customize

this.
Any always-enabled extension will still show up in the extension

manager, but it won't have a button for disabling the extension.

Similarly, the API will return an error when attempting to disable it,

if invoked through other means.
get_can_disable_extension(), and therefore disable_extension(), is

mindful of extensions that are depended on by another. If any dependent

extension is always-enabled, none of its dependencies anywhere in the

dependency chain can be disabled.
There are a few improvements to related functions to make all this work.

get_can_disable_extension() can now take an extension instance or ID

string along with the RegisteredExtension.

get_dependent_extensions() can now return only enabled extensions.

Testing Done

Unit tests passed.

Marked some extensions as always-enabled. Verified that they were
enabled on load/refresh, even when I forced a disable through other
means.

Verified that they could not be disabled via the UI. No button
appeared and API requests attempting to disable were met with an
error response.

Commits

Summary	ID
Add support for always-enabled extensions. The extension manager can now be given a list of extensions that must always be enabled. These act like enabled-by-default extensions, except that they cannot be disabled through `disable_extension()` or the UI, and will be considered enabled every time the extension manager loads. This and the enabled-by-default extensions can both be set in `settings`, or can now be set as attributes on the extension manager, giving implementations a central, non-settings-based place to customize this. Any always-enabled extension will still show up in the extension manager, but it won't have a button for disabling the extension. Similarly, the API will return an error when attempting to disable it, if invoked through other means. `get_can_disable_extension()`, and therefore `disable_extension()`, is mindful of extensions that are depended on by another. If any dependent extension is always-enabled, none of its dependencies anywhere in the dependency chain can be disabled. There are a few improvements to related functions to make all this work. `get_can_disable_extension()` can now take an extension instance or ID string along with the `RegisteredExtension`. `get_dependent_extensions()` can now return only enabled extensions.	fecfa03f833d37c5f2be6fd2c1ddc26a76c3f0af

Summary

Add support for always-enabled extensions.

The extension manager can now be given a list of extensions that must always be enabled. These act like enabled-by-default extensions, except that they cannot be disabled through `disable_extension()` or the UI, and will be considered enabled every time the extension manager loads. This and the enabled-by-default extensions can both be set in `settings`, or can now be set as attributes on the extension manager, giving implementations a central, non-settings-based place to customize this. Any always-enabled extension will still show up in the extension manager, but it won't have a button for disabling the extension. Similarly, the API will return an error when attempting to disable it, if invoked through other means. `get_can_disable_extension()`, and therefore `disable_extension()`, is mindful of extensions that are depended on by another. If any dependent extension is always-enabled, none of its dependencies anywhere in the dependency chain can be disabled. There are a few improvements to related functions to make all this work. `get_can_disable_extension()` can now take an extension instance or ID string along with the `RegisteredExtension`. `get_dependent_extensions()` can now return only enabled extensions.

fecfa03f833d37c5f2be6fd2c1ddc26a76c3f0af

Files

Issues

Description	From	Last Updated
Missing a ) after EXTENSIONS_ENABLED_BY_DEFAULT	david	June 10, 2026, 2:37 p.m.
And added an attribute for enabled by default extensions, which used to only exist as a setting.	maubin	June 10, 2026, 2:30 p.m.
This should say settings.EXTENSIONS_ALWAYS_ENABLED.	maubin	June 10, 2026, 2:31 p.m.
This is meant to say always_enabled_extension_ids for the :py:attr:.	maubin	June 10, 2026, 2:34 p.m.
This should say settings.EXTENSIONS_ENABLED_BY_DEFAULT. Also we should mention that this will always include the IDs in always_enabled_extension_ids (see my comment …	maubin	June 10, 2026, 2:34 p.m.
We should probably fetch get_dependent_extensions(extension_id) first and verify that all of the dependent extensions can be disabled before we allow …	david	June 10, 2026, 6:06 p.m.
This should say settings.EXTENSIONS_ENABLED_BY_DEFAULT	david	June 10, 2026, 6:06 p.m.
I think we should always include the always-enabled extension IDs in this list, regardless of if enabled_dy_default is UNSET or …	maubin	June 10, 2026, 2:37 p.m.
This is missing a Version Added.	maubin	June 11, 2026, 7:38 a.m.
This is missing a description.	maubin	June 11, 2026, 7:38 a.m.
Typo: testing -> Testing	david	June 10, 2026, 6:06 p.m.
Typo: testing -> Testing	david	June 10, 2026, 6:06 p.m.
Typo: testing -> Testing	david	June 10, 2026, 6:06 p.m.
Typo: testing -> Testing	david	June 10, 2026, 6:06 p.m.
Typo: testing -> Testing	david	June 10, 2026, 6:06 p.m.
'typing.TypeAlias' imported but unused Column: 5 Error code: F401	reviewbot	June 10, 2026, 6:30 p.m.

flake8 passed.

JSHint passed.

djblets/extensions/manager.py (Diff revision 1)

The issue has been resolved. Show all issues

And added an attribute for enabled by default extensions, which used to only exist as a setting.

djblets/extensions/manager.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should say settings.EXTENSIONS_ALWAYS_ENABLED.
```
djblets/extensions/manager.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This is meant to say always_enabled_extension_ids for the :py:attr:.
```

djblets/extensions/manager.py (Diff revision 1)

The issue has been resolved. Show all issues

This should say settings.EXTENSIONS_ENABLED_BY_DEFAULT. Also we should mention that this will always include the IDs in always_enabled_extension_ids (see my comment below).

djblets/extensions/manager.py (Diff revision 1)

The issue has been resolved. Show all issues

I think we should always include the always-enabled extension IDs in this list, regardless of if enabled_dy_default is UNSET or not. Otherwise its confusing wether the always-enabled extensions are expected to be in this list or not.

djblets/extensions/manager.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing a ) after EXTENSIONS_ENABLED_BY_DEFAULT
```

djblets/extensions/manager.py (Diff revision 1)

The issue has been resolved. Show all issues

We should probably fetch get_dependent_extensions(extension_id) first and verify that all of the dependent extensions can be disabled before we allow the dependency to be disabled.

djblets/extensions/manager.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should say settings.EXTENSIONS_ENABLED_BY_DEFAULT
```
djblets/extensions/tests/test_extension_manager.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Typo: testing -> Testing
```
djblets/extensions/tests/test_extension_manager.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Typo: testing -> Testing
```
djblets/extensions/tests/test_extension_manager.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Typo: testing -> Testing
```
djblets/extensions/tests/test_extension_manager.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Typo: testing -> Testing
```
djblets/extensions/tests/test_extension_manager.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Typo: testing -> Testing
```

Change Summary:


Added support for considering dependent extensions for disable checks.
get_can_disable_extension() now accepts an extension instance, ID string, or RegisteredExtension.
Fixed various typos and doc issues.
Added more unit tests.

Description:

		The extension manager can now be given a list of extensions that must
		always be enabled. These act like enabled-by-default extensions, except
		that they cannot be disabled through `disable_extension()` or the UI,
		and will be considered enabled every time the extension manager loads.

		This and the enabled-by-default extensions can both be set in
		`settings`, or can now be set as attributes on the extension manager,
		giving implementations a central, non-settings-based place to customize
		this.

		Any always-enabled extension will still show up in the extension
		manager, but it won't have a button for disabling the extension.
		Similarly, the API will return an error when attempting to disable it,
		if invoked through other means.
	+
	+	`get_can_disable_extension()`, and therefore `disable_extension()`, is
	+	mindful of extensions that are depended on by another. If any dependent
	+	extension is always-enabled, none of its dependencies anywhere in the
	+	dependency chain can be disabled.
	+
	+	There are a few improvements to related functions to make all this work.
	+	`get_can_disable_extension()` can now take an extension instance or ID
	+	string along with the `RegisteredExtension`.
	+	`get_dependent_extensions()` can now return only enabled extensions.

Commits:

	Summary	ID
	Add support for always-enabled extensions. The extension manager can now be given a list of extensions that must always be enabled. These act like enabled-by-default extensions, except that they cannot be disabled through `disable_extension()` or the UI, and will be considered enabled every time the extension manager loads. This and the enabled-by-default extensions can both be set in `settings`, or can now be set as attributes on the extension manager, giving implementations a central, non-settings-based place to customize this. Any always-enabled extension will still show up in the extension manager, but it won't have a button for disabling the extension. Similarly, the API will return an error when attempting to disable it, if invoked through other means.	828a5b487bca0e9ae1740f12952f16e5ec6c8f02
	Add support for always-enabled extensions. The extension manager can now be given a list of extensions that must always be enabled. These act like enabled-by-default extensions, except that they cannot be disabled through `disable_extension()` or the UI, and will be considered enabled every time the extension manager loads. This and the enabled-by-default extensions can both be set in `settings`, or can now be set as attributes on the extension manager, giving implementations a central, non-settings-based place to customize this. Any always-enabled extension will still show up in the extension manager, but it won't have a button for disabling the extension. Similarly, the API will return an error when attempting to disable it, if invoked through other means. `get_can_disable_extension()`, and therefore `disable_extension()`, is mindful of extensions that are depended on by another. If any dependent extension is always-enabled, none of its dependencies anywhere in the dependency chain can be disabled. There are a few improvements to related functions to make all this work. `get_can_disable_extension()` can now take an extension instance or ID string along with the `RegisteredExtension`. `get_dependent_extensions()` can now return only enabled extensions.	fecfa03f833d37c5f2be6fd2c1ddc26a76c3f0af

Diff:

Revision 2 (+1354 -110)

Show changes

	djblets/extensions/manager.py
	djblets/extensions/testing/testcases.py
	djblets/extensions/tests/test_extension_manager.py
	djblets/static/djblets/js/extensionsAdmin/views/extensionManagerView.ts

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

djblets/extensions/manager.py (Diff revision 2)
The issue has been resolved. Show all issues
```
'typing.TypeAlias' imported but unused

Column: 5
Error code: F401
```

Ship it! Fix it!

djblets/extensions/manager.py (Diff revisions 1 - 2)
An issue was opened. Show all issues
```
This is missing a Version Added.
```
djblets/extensions/manager.py (Diff revisions 1 - 2)
An issue was opened. Show all issues
```
This is missing a description.
```