• 
      

    Update unit tests for the latest setuptools dependency updates.

    Review Request #15102 — Created June 7, 2026 and discarded

    Information

    buildthings
    master

    Reviewers

    Setuptools now includes wheel as a dependency for editable installs
    and isolated build environments, which the unit tests weren't checking
    for. This is now included in the appropriate tests.

    It also changed how dependency version specifiers are represented.
    Instead of package>=1.0, it's now package >=1.0, with a space after
    the package. This affected some tests as well, though doesn't impact
    anything at package time.

    To match this, the setuptools dependency has been bumped to the latest
    major releaase. In a build environment, this will effectively always
    be the case, but now we're explicit about it and will have it in unit
    tests.

    All unit tests pass.

    Summary ID
    Update unit tests for the latest setuptools dependency updates.
    Setuptools now includes `wheel` as a dependency for editable installs and isolated build environments, which the unit tests weren't checking for. This is now included in the appropriate tests. It also changed how dependency version specifiers are represented. Instead of `package>=1.0`, it's now `package >=1.0`, with a space after the package. This affected some tests as well, though doesn't impact anything at package time. To match this, the `setuptools` dependency has been bumped to the latest major releaase. In a build environment, this will effectively always be the case, but now we're explicit about it and will have it in unit tests.
    5719ec5f227aa5afa59d4ac3cec0480d71f5567e
    Description From Last Updated

    Should we pin setuptools>=80 to match this behavior, at least in dev-requirements.txt?

    david david
    david
    1. 
        
    2. Show all issues

      Should we pin setuptools>=80 to match this behavior, at least in dev-requirements.txt?

      1. I was trying to figure out what to do here, but I think since this is a build-time dependency and it's always going to get the latest version at build time, there's no point in limiting to dev-requirements.txt. We're right now just setuptools==latest. Given that, I'll just bump to the latest major.

    3. 
        
    chipx86
    chipx86
    Review request changed
    Status:
    Discarded
    Change Summary:

    I think this was ultimately environmental. These updates fail on a brand-new environment on all Python versions.