• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Add an option for letting confetti fall through the bottom of the viewport.
    
 
    

    



 
    
 
    

  Review Request #15094
  —
  Created June 5, 2026 and updated 

 
    


    




    




    






 
    
  
    
   Information

  
    



    
 
 
    
  maubin
 
    

    





    
 
 
    
  Review Board
 
    

    





    
 
 
    
  release-8.x
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewboard
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    This adds an option to remove the bottom of the viewport as a mandatory
platform. When this is set, pieces will fall through the bottom of the
viewport instead of landing on it. This is useful when adding confetti
to pages that have a vertical scroll, when you scroll the confetti ends
up looking like its floating on the page.

This change also switches the position of the canvas that holds the
confetti from fixed to absolute, so that confetti sticks onto the
platform it landed on when the page scrolls, instead of being sticky to
the viewport when scrolling.
    
 
    

    





  

    
 
 
    
  
    Saw that behavior was normal with the option disabled, and that
    
confetti falls through the the bottom of the viewport when the option
    
is set.
    
 
    

    




 
    

    





    
 
    




  
    
 
 
    
  


    
 
    
  
   
    

    Summary
    ID

   
    
      
  

   
    

    

     
    
      Add an option for letting confetti fall through the bottom of the viewport.
      
    This adds an option to remove the bottom of the viewport as a mandatory
platform. When this is set, pieces will fall through the bottom of the
viewport instead of landing on it. This is useful when adding confetti
to pages that have a vertical scroll, when you scroll the confetti ends
up looking like its floating on the page.

This change also switches the position of the canvas that holds the
confetti from fixed to absolute, so that confetti sticks onto the
platform it landed on when the page scrolls, instead of being sticky to
the viewport when scrolling.
    
     
    

        		
    67b9f80e14ace73e400dcae2a89dae8527bd4e3e

   
    


      
 
    

    
    
 
    

    






 





    
 
 
 
    
  
    
   
    
    
    
     
    
    
    
      
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
    
    
   
    
   
    
    
     
    
      Description
      From
      Last Updated
     
    
        
    



     
    
      
       
       
    It's generally nice to keep flags in a positive state, like floorEnabled, so that it's consistent what a true or …
    
          		
      


chipx86

  chipx86
 

      
      
       
      
     
    



     
    
      
       
       
    Would it make sense to conditionally create or not create #floor based on the flag, and then check that instead?
    
          		
      


chipx86

  chipx86
 

      
      
       
      
     
    

        
   
    
  
    
 
    

    




 
    

    



  
    
 
    

    


    












    
 




 

    


 













    
 





 
    
  
    
   
    



chipx86




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    

   
    

    
    





  chipx86
 


    
    
    
    
     


      


     
    
    
   
    


  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 

















    2. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/ui/views/confettiView.ts
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      It's generally nice to keep flags in a positive state, like floorEnabled, so that it's consistent what a true or a false means. Can we invert this one?
      

      This should also sort alphabetically below the ms.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 






    3. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/ui/views/confettiView.ts
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Would it make sense to conditionally create or not create #floor based on the flag, and then check that instead?
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      4. 




    4. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      5. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



maubin




   
    
   
    
  
    
 
    


 
    
  
    

   
    

   
    

    
    
Review request changed
    
    
    
    
     


      


     
    
    
   
    


  
    
  
    
  
    




    









  
    
   
    
    Commits:
   
    
   
    
    
    



    
 
    
  
   
    

    

    Summary
    ID

   
    
      
  

   
    

    

    

     
    
      Add an option for letting confetti fall through the bottom of the viewport.
      
    This adds an option to remove the bottom of the viewport as a mandatory
platform. When this is set, pieces will fall through the bottom of the
viewport instead of landing on it. This is useful when adding confetti
to pages that have a vertical scroll, when you scroll the confetti ends
up looking like its floating on the page.

This change also switches the position of the canvas that holds the
confetti from fixed to absolute, so that confetti sticks onto the
platform it landed on when the page scrolls, instead of being sticky to
the viewport when scrolling.
    
     
    

        		
    531a04c9b941e660c7014ca2a1ff7f2bbca7689e

   
    



   
    

    

    

     
    
      Add an option for letting confetti fall through the bottom of the viewport.
      
    This adds an option to remove the bottom of the viewport as a mandatory
platform. When this is set, pieces will fall through the bottom of the
viewport instead of landing on it. This is useful when adding confetti
to pages that have a vertical scroll, when you scroll the confetti ends
up looking like its floating on the page.

This change also switches the position of the canvas that holds the
confetti from fixed to absolute, so that confetti sticks onto the
platform it landed on when the page scrolls, instead of being sticky to
the viewport when scrolling.
    
     
    

        		
    67b9f80e14ace73e400dcae2a89dae8527bd4e3e

   
    


      
 
    

    


    

   
    
  
    




  
    
   
    
    Diff:
   
    
   
    
    
     Revision 2 (+114 -46)
    Show changes
     
        reviewboard/static/rb/js/ui/views/confettiView.ts 
     
    
   
    
  
    





    



    
 
    
  
    Checks run (2 succeeded)
    


  
    
 flake8
 passed.
 


    


  
    
 JSHint
 passed.