Restore a setup.py for package building.
Review Request #15067 — Created May 19, 2026 and submitted
rbintegrations was updated to switch to pyproject.toml, which uses
the package backend in Review Board. However, this means it needs to be
able to pull down Review Board in an isolated build environment in order
to get to the package backend. This isn't feasible today, since that's
not released, and it always means we'll be using the released and not
in-development version of Review Board.Ideally we'd be able to use
.local-packagesto point to Review Board
here, but that's not viable because we can't usebuildthingsfor this.
In the future, there will be anrbextpackage built on that, but that
does us no good right now.However, we can restore
setup.pyand use that directly to kick off the
build. This effectively removes the isolated build environment, so long
as we runsetup.pyinstead ofpython -m build. This isn't going to
work forever, but it's the same approach we use for all other
extensions.This
setup.pyis minimal. In modern setuptools, it will kick off the
build but pull all metadata frompyproject.toml. This gives us a
bridge toward modern builds but restores the ability to deploy and
release this.
Successfully built packages manually and with beanbag-tools.
Note that
python -m buildwill still fail until Review Board 8
is released.
| Summary | ID |
|---|---|
| b326413b64584c978bf9c1fa4cf166147ade893c |