Summary

Provide --repository-url to ClearCase

Review Request #1505 — Created April 3, 2010 and submitted

Information

Owner

jan.koprowski

Repository

RBTools

Branch

master

Bugs

1597, 1598

Depends On

Reviewers

Groups

reviewboard

People

Description

In my company there is some custom access to vobs in dynamic view.
Difference is that there exist two assumptions:
1) We want ACL i old ClearCase so we do it on filesystem layer
2) Many users want to made their own dynamic view on unix system

This two assumptions follow to non standard clearcase dynamic view paths in
system. On filesystem looks like:

/view/user1_view/vobs
/view/user2_view/vobs
/view/user3_view/vobs

Now post review assume the path start from /vobs what is not true.
IMHO there is unused --repository-url parameter witch is perfect in meaning
to make customize "place of view == repository url" for clearcase.

--repository-url "/view/user1_view" 

will make the given as parameter path will be the prefix to /vobs. 
There is only one change. This parameter now works with --revision-range or
--diff-file. For clearcase they have sens also without any of this.

Testing Done

$ post-review -n -d --server "http://localhost:10000/" --repository-url "/view/user1_view/" index.wsgi
>>> svn info /view/user1_view/
>>> git rev-parse --git-dir
>>> hg root
>>> cleartool pwv -short
>>> repository info: Path: /view/reviewboard.diffview/vobs/, Base path: /view/reviewboard.diffview/vobs/, Supports changesets: False
>>> cleartool desc -pre /view/user1_view/vobs/SCM_tools/scripts/ReleaseRobot/index.wsgi
>>> cleartool desc -fmt %Vn /view/user1_view/vobs/SCM_tools
>>> cleartool desc -fmt %Vn /view/user1_view/vobs/SCM_tools/scripts
>>> cleartool desc -fmt %Vn /view/user1_view/vobs/SCM_tools/scripts/ReleaseRobot
--- /view/user1_view/vobs/SCM_tools/@@/main/int_02.04_GK/2/scripts/@@/main/6/ReleaseRobot/@@/main/3/index.wsgi/@@/main/int_02.04_GK/0   2002-02-21 23:30:39.942229878 -0800
+++ /view/user1_view/vobs/SCM_tools/scripts/ReleaseRobot/index.wsgi   2002-02-21 23:30:50.442260588 -0800
@@ -4,6 +4,8 @@

 from mako.lookup import TemplateLookup
 from werkzeug import Request
+
+# dummy checkout

 def bywwlistdir(directory, config):
     """Return directory sorted by work week"""


 post-review -d --server "http://localhost:10000/" --cc-root "/view/jkoprows_ccgsys" --repository-url "/view/jkoprows_ccgsys/vobs" index.wsgi
>>> svn info /view/jkoprows_ccgsys/vobs
>>> git rev-parse --git-dir
>>> hg root
>>> cleartool pwv -short
>>> repository info: Path: /view/jkoprows_ccgsys/vobs, Base path: /view/jkoprows_ccgsys/vobs, Supports changesets: False
>>> cleartool desc -pre /view/jkoprows_ccgsys/vobs/SCM_tools/scripts/ReleaseRobot/index.wsgi
>>> cleartool desc -fmt %Vn /view/jkoprows_ccgsys/vobs/SCM_tools
>>> cleartool desc -fmt %Vn /view/jkoprows_ccgsys/vobs/SCM_tools/scripts
>>> cleartool desc -fmt %Vn /view/jkoprows_ccgsys/vobs/SCM_tools/scripts/ReleaseRobot
>>> Looking for 'localhost /' cookie in /user/jkoprows/.post-review-cookies.txt
>>> Cookie file loaded, but no cookie for this server
==> Review Board Login Required
Enter username and password for Review Board at http://localhost:10000/
Username: admin
Password:
>>> Logging in with username "admin"
>>> HTTP POSTing to http://localhost:10000/api/json/accounts/login/: {'username': 'admin', 'password': '**************'}
>>> Logged in.
>>> Attempting to create review request on /view/jkoprows_ccgsys/vobs for None
>>> HTTP POSTing to http://localhost:10000/api/json/reviewrequests/new/: {'repository_path': '/view/jkoprows_ccgsys/vobs'}
>>> Review request created
>>> Attempting to set field 'description' to 'jkoprows_ccgsys
VIEWTYPE: dynamic
' for review request '2'
>>> HTTP POSTing to http://localhost:10000/api/json/reviewrequests/2/draft/set/: {'description': 'jkoprows_ccgsys\nVIEWTYPE: dynamic\n'}
>>> Uploading diff, size: 494
>>> HTTP POSTing to http://localhost:10000/api/json/reviewrequests/2/diff/new/: {'basedir': '/view/jkoprows_ccgsys/vobs'}
Review request #2 posted.

http://localhost:10000/r/2

Change Summary:

I change the manner of the --repository-url from this meaning and provide --cc-root.

--repository-url for ClearCase target to which CC repository on ReviewBoard we told about
--cc-root target to the local developer repository placement in system

Summary:

Provide --repository-url for ClearCase

Provide --repository-url and --cc-root for ClearCase

Testing Done:

		$ post-review -n -d --server "http://localhost:10000/" --repository-url "/view/user1_view/" index.wsgi

		svn info /view/user1_view/ git rev-parse --git-dir hg root cleartool pwv -short repository info: Path: /view/reviewboard.diffview/vobs/, Base path: /view/reviewboard.diffview/vobs/, Supports changesets: False cleartool desc -pre /view/user1_view/vobs/SCM_tools/scripts/ReleaseRobot/index.wsgi cleartool desc -fmt %Vn /view/user1_view/vobs/SCM_tools cleartool desc -fmt %Vn /view/user1_view/vobs/SCM_tools/scripts cleartool desc -fmt %Vn /view/user1_view/vobs/SCM_tools/scripts/ReleaseRobot --- /view/user1_view/vobs/SCM_tools/@@/main/int_02.04_GK/2/scripts/@@/main/6/ReleaseRobot/@@/main/3/index.wsgi/@@/main/int_02.04_GK/0 2002-02-21 23:30:39.942229878 -0800 +++ /view/user1_view/vobs/SCM_tools/scripts/ReleaseRobot/index.wsgi 2002-02-21 23:30:50.442260588 -0800 @@ -4,6 +4,8 @@

		from mako.lookup import TemplateLookup
		from werkzeug import Request
		+
		+# dummy checkout

		def bywwlistdir(directory, config):
		"""Return directory sorted by work week"""
	+
	+
	+
	+	post-review -d --server "http://localhost:10000/" --cc-root "/view/jkoprows_ccgsys" --repository-url "/view/jkoprows_ccgsys/vobs" index.wsgi
	+
	+	svn info /view/jkoprows_ccgsys/vobs git rev-parse --git-dir hg root cleartool pwv -short repository info: Path: /view/jkoprows_ccgsys/vobs, Base path: /view/jkoprows_ccgsys/vobs, Supports changesets: False cleartool desc -pre /view/jkoprows_ccgsys/vobs/SCM_tools/scripts/ReleaseRobot/index.wsgi cleartool desc -fmt %Vn /view/jkoprows_ccgsys/vobs/SCM_tools cleartool desc -fmt %Vn /view/jkoprows_ccgsys/vobs/SCM_tools/scripts cleartool desc -fmt %Vn /view/jkoprows_ccgsys/vobs/SCM_tools/scripts/ReleaseRobot Looking for 'localhost /' cookie in /user/jkoprows/.post-review-cookies.txt Cookie file loaded, but no cookie for this server ==> Review Board Login Required Enter username and password for Review Board at http://localhost:10000/ Username: admin Password: Logging in with username "admin" HTTP POSTing to http://localhost:10000/api/json/accounts/login/: {'username': 'admin', 'password': '**'} Logged in. Attempting to create review request on /view/jkoprows_ccgsys/vobs for None HTTP POSTing to http://localhost:10000/api/json/reviewrequests/new/: {'repository_path': '/view/jkoprows_ccgsys/vobs'} Review request created Attempting to set field 'description' to 'jkoprows_ccgsys VIEWTYPE: dynamic ' for review request '2' HTTP POSTing to http://localhost:10000/api/json/reviewrequests/2/draft/set/: {'description': 'jkoprows_ccgsys\nVIEWTYPE: dynamic\n'} Uploading diff, size: 494 HTTP POSTing to http://localhost:10000/api/json/reviewrequests/2/diff/new/: {'basedir': '/view/jkoprows_ccgsys/vobs'} Review request #2 posted.
	+
	+	http://localhost:10000/r/2

Bugs:

1598

Diff:

Revision 2 (+19 -13)

Show changes

rbtools/postreview.py

Change Summary:: Add branch information
Branch:: master

Ship it!

Looks good. You'll want to update the post-review doc in the reviewboard repo to reflect this change. I added some documentation a while back that explains how to hack your way through the hard-coded variables you removed here...

jan.koprowski April 9, 2010, 3:44 p.m.

I'll be happy to write some stuff about ClearCase usage model with ReviewBoard. My experiance in this manner growing day-to-day.
But this depends how I should do this? Is this will be access to part of Your documentation, or send text to review in some format?

djs April 11, 2010, 1:07 p.m.

You'll want to edit the reviewboard/docs/manual/users/tools/post-review.txt file in the Clearcase section. You can see the current doc online at http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/

jan.koprowski April 11, 2010, 9:44 p.m.

I don't see it before. I will update that.

rbtools/postreview.py (Diff revision 2)
```
Combine to one line.
```
1. jan.koprowski May 15, 2010, 10:01 p.m.
  Got it.
rbtools/postreview.py (Diff revision 2)
```
Here too.
```
1. jan.koprowski May 15, 2010, 10:02 p.m.
  Yes sir! :)

rbtools/postreview.py (Diff revision 2)

Can you rename this to --clearcase-root?

I'd like to start getting post-review's SCM-specific arguments to be prefixed consistently with the SCM name. We'll need to do this for --label too, but it doesn't have to be this change (and we'd need backwards-compatibility anyway).

jan.koprowski May 15, 2010, 10:02 p.m.

No problem :) I will make parameters consist.

rbtools/postreview.py (Diff revision 2)
```
Make sure these wrap to 80 chars.
```
1. jan.koprowski May 15, 2010, 10:02 p.m.
  I will check this :)

rbtools/postreview.py (Diff revision 2)

This logic (or something like it) needs to be preserved for Subversion. Probably belongs in the Subversion SCMClient somewhere.

jan.koprowski May 15, 2010, 10:03 p.m.

So... What I should to do? Add more logic? This condition will be huge!

chipx86 June 1, 2010, 7:01 p.m.

Sorry, missed this.

Maybe have a SCMClient.check_options function that is called once we know the SCMClient. The existing code can move into the SVNClient.check_options, and then you should get what you want.

Change Summary:

Fixed.

Diff:

Revision 3 (+34 -14)

Show changes

rbtools/postreview.py

rbtools/postreview.py (Diff revision 3)

We're actually not adding repository_url. We're adding clearcase_root_path.

I'm confused as to the difference between these. Can you go over that? Do we really want both --clearcase-root and --repository-url, or just one?

jan.koprowski June 27, 2010, 4:05 p.m.

If we want to be clear ClearCase doesn't have something like repository at all. There is already big mess in ClearCase implementation so I can't understand why You still try to fix my patches. Please read ClearCase documentation updated by me and then You understand why.

Change Summary:

Updated to version without ClearCase root path.

Diff:

Revision 4 (+22 -14)

Show changes

rbtools/postreview.py

Change Summary:: --clearcase-root is no more subject of this review because was removed.
Summary:: Provide --repository-url and --cc-root for ClearCase
Provide --repository-url to ClearCase

Ship it!

```
Committed as 3fabeeb. Thanks!
```