Summary

Update typing: Tuple[...] and Set[...]

Review Request #15038 — Created May 11, 2026 and submitted May 14, 2026, 9:19 a.m.

Information

Owner

david

Repository

Djblets

Branch

master

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This change updates legacy type hints that use the old Set[...] form
to be set[...], and Tuple[...] to be tuple[...].

Because I want to keep this tightly focused and easy to review, this
does not make any changes to other legacy type hints, documentation,
etc., even within the changed lines. Those will come in future changes.

Testing Done

Ran unit tests.

Commits

Summary	ID
Update typing: Tuple[...] and Set[...] This change updates legacy type hints that use the old `Set[...]` form to either be `set[...]`, and `Tuple[...]` to be `tuple[...]`. Because I want to keep this tightly focused and easy to review, this does not make any changes to other legacy type hints, documentation, etc., even within the changed lines. Those will come in future changes. Testing Done: Ran unit tests.	kyyqtpnwqrytxvrwwwxnwzlrvvotrzlt

Summary

Update typing: Tuple[...] and Set[...]

This change updates legacy type hints that use the old `Set[...]` form to either be `set[...]`, and `Tuple[...]` to be `tuple[...]`. Because I want to keep this tightly focused and easy to review, this does not make any changes to other legacy type hints, documentation, etc., even within the changed lines. Those will come in future changes. Testing Done: Ran unit tests.

kyyqtpnwqrytxvrwwwxnwzlrvvotrzlt

Issues

Description	From	Last Updated
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	May 11, 2026, 9:48 a.m.

flake8 failed.

JSHint passed.

flake8

djblets/datagrid/grids.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (80 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Update typing: Tuple[...] and Set[...] This change updates legacy type hints that use the old `Set[...]` form to either be `set[...]`, and `Tuple[...]` to be `tuple[...]`. Because I want to keep this tightly focused and easy to review, this does not make any changes to other legacy type hints, documentation, etc., even within the changed lines. Those will come in future changes. Testing Done: Ran unit tests.	kyyqtpnwqrytxvrwwwxnwzlrvvotrzlt
	Update typing: Tuple[...] and Set[...] This change updates legacy type hints that use the old `Set[...]` form to either be `set[...]`, and `Tuple[...]` to be `tuple[...]`. Because I want to keep this tightly focused and easy to review, this does not make any changes to other legacy type hints, documentation, etc., even within the changed lines. Those will come in future changes. Testing Done: Ran unit tests.	kyyqtpnwqrytxvrwwwxnwzlrvvotrzlt

Diff:

Revision 2 (+58 -62)

Show changes

	djblets/cache/backend.py
	djblets/datagrid/grids.py
	djblets/forms/widgets.py
	djblets/integrations/urls.py
	djblets/integrations/tests/test_hooks.py
	djblets/pipeline/compilers/rollup.py
	djblets/secrets/token_generators/registry.py
	djblets/util/properties.py
	2 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:: grammar
Description:: This change updates legacy type hints that use the old Set[...] form
~ to either be set[...], and Tuple[...] to be tuple[...].
~ to be set[...], and Tuple[...] to be tuple[...].

Because I want to keep this tightly focused and easy to review, this
does not make any changes to other legacy type hints, documentation,
etc., even within the changed lines. Those will come in future changes.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (f8086b5)

		This change updates legacy type hints that use the old `Set[...]` form
~		to either be `set[...]`, and `Tuple[...]` to be `tuple[...]`.
	~	to be `set[...]`, and `Tuple[...]` to be `tuple[...]`.

		Because I want to keep this tightly focused and easy to review, this
		does not make any changes to other legacy type hints, documentation,
		etc., even within the changed lines. Those will come in future changes.

djblets/datagrid/grids.py (Diff revision 1)