• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Fix state leakage in certificate manager tests.
    
 
    

    



 
    
 
    

  Review Request #15033
  —
  Created May 8, 2026 and submitted 

 
    


    




    




    






 
    
  
    
   Information

  
    



    
 
 
    
  david
 
    

    





    
 
 
    
  Review Board
 
    

    





    
 
 
    
  release-8.x
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewboard
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    I was hitting intermittent failures in the test suite when running with
    
pytest-xdist. It turns out that three of the certificate manager tests
    
were polluting the in-memory siteconfig object without cleaning up
    
after:
    

      

    • test_storage_backend_with_custom
      • 

    • test_storage_backend_after_setting_change
      • 

    • test_storage_backend_with_missing_backend
      • 

    

    This change adds to the tearDown method to clean up the offending
    
state.
    
 
    

    





  

    
 
 
    
  
    Ran unit tests with xdist a few times to verify that we no longer had
    
state leakage.
    
 
    

    




 
    

    





    
 
    




  
    
 
 
    
  


    
 
    
  
   
    

    Summary
    ID

   
    
      
  

   
    

    

     
    
      Fix state leakage in certificate manager tests.
      
    I was hitting intermittent failures in the test suite when running with
pytest-xdist. It turns out that three of the certificate manager tests
were polluting the in-memory siteconfig object without cleaning up
after:

- `test_storage_backend_with_custom`
- `test_storage_backend_after_setting_change`
- `test_storage_backend_with_missing_backend`

This change adds a `tearDown` method to clean up after.

Testing Done:
Ran unit tests with xdist a few times to verify that we no longer had
state leakage.
    
     
    

        		
    skltkqtqsswutsnrkkmzpmrqupunzqmu

   
    


      
 
    

    
    
 
    

    






 









 
    

    



  
    
 
    

    


    












    
 




 

    


 













    
 





 
    
  
    
   
    



chipx86




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    

   
    

    
    





  chipx86
 


    
    
    
    
     


      


     
    
    
   
    


  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Ship It!
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



david




   
    
   
    
  
    
 
    


 
    
  
    

   
    

   
    

    
    
Review request changed
    
    
    
    
     


      


     
    
    
   
    


  
    
  
    
  
    




    

  
    
   
    
    Status:
   
    
   
    

    Completed

   
    
  
    



  
    
   
    
    Change Summary:
   
    
   
    
    
    Pushed to release-8.x (1eac699)