Change Summary:
Updated the patch to be compatible with Python 2.4, which doesn't support accessing the hostname or username from the urlparse result.
Diff: |
Revision 2 (+25 -2) |
---|
Review Request #1503 — Created April 2, 2010 and submitted
Information | |
---|---|
phil.orwig | |
Review Board | |
releases-1.5beta1 | |
1592 | |
Reviewers | |
reviewboard | |
Modified SCMTool.check_repository to properly split out the username from the URI if one was given.
Updated the patch to be compatible with Python 2.4, which doesn't support accessing the hostname or username from the urlparse result.
Diff: |
Revision 2 (+25 -2) |
---|
reviewboard/scmtools/core.py (Diff revision 2) |
---|
Log messages should be in sentence case. It would also help to prefix with the SCM type (could just use the class name).
reviewboard/scmtools/core.py (Diff revision 2) |
---|
Not sure I'm wild about this name. I'd like it to be a little more descriptive given its purpose. Maybe get_auth_from_uri. Also, why is this a classmethod?