Summary

Improve UX with auto-renewing licenses.

Review Request #15023 — Created April 30, 2026 and submitted May 6, 2026, 11:17 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change makes it so we track the auto-renew state (provided during
license checks). In the case that a license is set to auto-renew, we
hide the banner (up to 3 days past the soft expiration date) and change
the text shown in the licenses page.

Testing Done


Ran unit tests.
Ran JS tests.
Set a license to auto-renew monthly. Verified that the banner was not

  shown and the licenses page showed "renews ..."
Set up an auto-renew license with an expiration date 5 days past. Saw

  that the banner was correctly shown and the licenses page showed that

  the license(s) were expired.
Set up a month-to-month license and turned off auto-renew. Saw that

  the banner was shown and the licenses page showed "expires ..."

Commits

Summary	ID
Improve UX with auto-renewing licenses. When a license is set to auto-renew, especially on a month-to-month basis, the experience with the banner and the licenses page was sub-par. The banner would always appear saying that the license was expiring soon (since it was < 30 days away), and the licenses page would show that the license is "expiring on" rather than the license is "renewing on". This change makes it so we track the auto-renew state (provided during license checks). In the case that a license is set to auto-renew, we hide the banner (up to 3 days past the soft expiration date) and change the text shown in the licenses page. Testing Done: - Ran unit tests. - Ran JS tests. - Set a license to auto-renew monthly. Verified that the banner was not shown and the licenses page showed "renews ..." - Set up an auto-renew license with an expiration date 5 days past. Saw that the banner was correctly shown and the licenses page showed that the license(s) were expired. - Set up a month-to-month license and turned off auto-renew. Saw that the banner was shown and the licenses page showed "expires ..."	lvxvmmrnqwwmwpmnktxmozkzwtpllxor

Summary

Improve UX with auto-renewing licenses.

When a license is set to auto-renew, especially on a month-to-month basis, the experience with the banner and the licenses page was sub-par. The banner would always appear saying that the license was expiring soon (since it was < 30 days away), and the licenses page would show that the license is "expiring on" rather than the license is "renewing on". This change makes it so we track the auto-renew state (provided during license checks). In the case that a license is set to auto-renew, we hide the banner (up to 3 days past the soft expiration date) and change the text shown in the licenses page. Testing Done: - Ran unit tests. - Ran JS tests. - Set a license to auto-renew monthly. Verified that the banner was not shown and the licenses page showed "renews ..." - Set up an auto-renew license with an expiration date 5 days past. Saw that the banner was correctly shown and the licenses page showed that the license(s) were expired. - Set up a month-to-month license and turned off auto-renew. Saw that the banner was shown and the licenses page showed "expires ..."

lvxvmmrnqwwmwpmnktxmozkzwtpllxor

Issues

Description	From	Last Updated
The emdash seems wrong here. This should just be a new sentence. Actually, everything after the emdash is pretty hard …	chipx86	May 6, 2026, 4:19 p.m.
This isn't needed. The whole class is new in 8.0.	chipx86	May 6, 2026, 4:19 p.m.
Not 100% sure what "summaries and detail rows" is really meaning here. Can we either spell it out, or be …	chipx86	May 6, 2026, 4:20 p.m.
This isn't needed.	chipx86	May 6, 2026, 4:20 p.m.
The heading?	chipx86	May 6, 2026, 4:20 p.m.
Rather than "no warning chrome," can we just say (maybe as a new sentence) that Review Board will not show …	chipx86	May 6, 2026, 4:21 p.m.
This isn't needed, since all this is new in 8.0.	chipx86	May 6, 2026, 4:21 p.m.

flake8 passed.

JSHint passed.

Most of this seems fine, but the wording in docs confuses me in several places.

reviewboard/licensing/license.py (Diff revision 1)

The issue has been resolved. Show all issues

The emdash seems wrong here. This should just be a new sentence. Actually, everything after the emdash is pretty hard for me to parse. It needs rewording and maybe split up a bit?

reviewboard/licensing/license.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This isn't needed. The whole class is new in 8.0.
```

reviewboard/licensing/license.py (Diff revision 1)

The issue has been resolved. Show all issues

Not 100% sure what "summaries and detail rows" is really meaning here. Can we either spell it out, or be more generic saying "the UI won't show auto-renewing licenses a expiring" or something (if that's the case)?

reviewboard/licensing/license.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This isn't needed.
```
reviewboard/licensing/license.py (Diff revision 1)
The issue has been resolved. Show all issues
```
The heading?
```

reviewboard/static/rb/js/admin/models/licenseModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

Rather than "no warning chrome," can we just say (maybe as a new sentence) that Review Board will not show a license that's auto-renewing as expiring soon?

reviewboard/static/rb/js/admin/models/licenseModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
This isn't needed, since all this is new in 8.0.
```

Commits:

	Summary	ID
	Improve UX with auto-renewing licenses. When a license is set to auto-renew, especially on a month-to-month basis, the experience with the banner and the licenses page was sub-par. The banner would always appear saying that the license was expiring soon (since it was < 30 days away), and the licenses page would show that the license is "expiring on" rather than the license is "renewing on". This change makes it so we track the auto-renew state (provided during license checks). In the case that a license is set to auto-renew, we hide the banner (up to 3 days past the soft expiration date) and change the text shown in the licenses page. Testing Done: - Ran unit tests. - Ran JS tests. - Set a license to auto-renew monthly. Verified that the banner was not shown and the licenses page showed "renews ..." - Set up an auto-renew license with an expiration date 5 days past. Saw that the banner was correctly shown and the licenses page showed that the license(s) were expired. - Set up a month-to-month license and turned off auto-renew. Saw that the banner was shown and the licenses page showed "expires ..."	lvxvmmrnqwwmwpmnktxmozkzwtpllxor
	Improve UX with auto-renewing licenses. When a license is set to auto-renew, especially on a month-to-month basis, the experience with the banner and the licenses page was sub-par. The banner would always appear saying that the license was expiring soon (since it was < 30 days away), and the licenses page would show that the license is "expiring on" rather than the license is "renewing on". This change makes it so we track the auto-renew state (provided during license checks). In the case that a license is set to auto-renew, we hide the banner (up to 3 days past the soft expiration date) and change the text shown in the licenses page. Testing Done: - Ran unit tests. - Ran JS tests. - Set a license to auto-renew monthly. Verified that the banner was not shown and the licenses page showed "renews ..." - Set up an auto-renew license with an expiration date 5 days past. Saw that the banner was correctly shown and the licenses page showed that the license(s) were expired. - Set up a month-to-month license and turned off auto-renew. Saw that the banner was shown and the licenses page showed "expires ..."	lvxvmmrnqwwmwpmnktxmozkzwtpllxor

Branch:

release-8.x

master

Diff:

Revision 2 (+306 -4)

Show changes

	reviewboard/licensing/license.py
	reviewboard/licensing/provider.py
	reviewboard/licensing/tests/test_license_info.py
	reviewboard/licensing/tests/test_license_provider.py
	reviewboard/licensing/tests/test_licenses_view.py
	reviewboard/static/rb/js/admin/models/licenseModel.ts
	reviewboard/static/rb/js/admin/views/licenseView.ts
	reviewboard/static/rb/js/admin/views/tests/licenseViewTests.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-8.x (d785a1c)