postreview.py: use last message for summary

 






 

 


  Review Request #1502
  —
  Created April 2, 2010 and submitted

 


















 

  

   Information

  





 
 

  mw_triad
 









 
 

  RBTools
 









 
 

  
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
postreview.py: use last message for summary

While --guess-summary for git has always claimed to use only the last
commit, it would actually use the concatenation of all log summaries as
the request summary. Fix it to actually use only the last one, as
claimed.

 








  


 
 

  

 







 









 





  








 









 






  

 








 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    I'm fine with it, but I guess the question we must ask now is, which do we want? Are people relying on the current behavior?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      IIRC the current behavior results in mojibake (bad characters in place of would-be line breaks); it seems unlikely anyone would be "relying" on that.

I forget, do I have commit access somehow these days, or do you commit this?
      
 
      

      2. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 









     

    

   

  

  

   
   Loading...