Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Avoid logging about missing cert keys if not adding a trust cert.
Review Request #15018 — Created April 16, 2026 and submitted
When building an SSL context, we were logging when a key for a client
cert couldn't be found when there wasn't even a client cert to begin
with. We now log this only when we know we have a cert but no key.
Hit this while testing another change and verified it was fixed.
| Summary | ID |
|---|---|
| a3501b00da66dd975516219e55be89cdf57bff3c |
| Description | From | Last Updated |
|---|---|---|
|
Your summary/description say "trust cert" but the change is inside the client certificate path. |
david
|
Review request changed
- Description:
-
~ When building an SSL context, we were logging when a key for a trust
~ cert couldn't be found when there wasn't even a trust cert to begin ~ When building an SSL context, we were logging when a key for a client
~ cert couldn't be found when there wasn't even a client cert to begin with. We now log this only when we know we have a cert but no key.