Summary

Fix a bug with the Review Summary column.

Review Request #15015 — Created April 16, 2026 and submitted April 22, 2026, 8:17 p.m.

Information

Owner

maubin

Repository

Review Board

Branch

release-8.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

In our recent datagrid updates, we gave the ReviewSummaryColumn a

link_css_class of review-request-link. This is the class used for

review request info boxes, which takes the cell's href target and uses

that to create the review request info box. The href target for review

summary cells is the review URL, but the review request info box

requires a review request URL to work properly. This was causing a bug

where the info box was populated with a poorly formatted review request

page.
Previously we didn't set the link_css_class for the

ReviewSummaryColumn, which meant that the review request info box

wouldn't show up when hovering over the review request summary of the

column. This change fixes the bug and improves the behaviour, we now

supply the review request URL to the info box through the column's

render context and a custom template for the review summary cells.

Testing Done


Ran unit tests.
Hovered over review summary column cells, saw the bug was fixed.
Hovered over review request summary column cells.

Commits

Summary	ID
Fix a bug with the Review Summary column. In our recent datagrid updates, we gave the `ReviewSummaryColumn` a `link_css_class` of `review-request-link`. This is the class used for review request info boxes, which takes the cell's `href` target and uses that to create the review request info box. The `href` target for review summary cells is the review URL, but the review request info box requires a review request URL to work properly. This was causing a bug where the info box was populated with a poorly formatted review request page. Previously we didn't set the `link_css_class` for the `ReviewSummaryColumn`, which meant that the review request info box wouldn't show up when hovering over the review request summary of the column. This change fixes the bug and improves the behaviour, we now supply the review request URL to the info box through the column's render context and a custom template for the review summary cells.	e27db99cdd21f4b40d3b2722ad7f9f8c19adf160

Summary

Fix a bug with the Review Summary column.

In our recent datagrid updates, we gave the `ReviewSummaryColumn` a `link_css_class` of `review-request-link`. This is the class used for review request info boxes, which takes the cell's `href` target and uses that to create the review request info box. The `href` target for review summary cells is the review URL, but the review request info box requires a review request URL to work properly. This was causing a bug where the info box was populated with a poorly formatted review request page. Previously we didn't set the `link_css_class` for the `ReviewSummaryColumn`, which meant that the review request info box wouldn't show up when hovering over the review request summary of the column. This change fixes the bug and improves the behaviour, we now supply the review request URL to the info box through the column's render context and a custom template for the review summary cells.

e27db99cdd21f4b40d3b2722ad7f9f8c19adf160

Issues

Description	From	Last Updated
Should be SafeString not str	david	April 19, 2026, 8:12 p.m.
We're not expecting any exceptions from get_absolute_url, so this could be a bit simpler: render_context['review_request_url'] = \ obj.review_request.get_absolute_url() try: return …	david	April 19, 2026, 8:14 p.m.
This needs "Args" and "Returns"	david	April 19, 2026, 8:26 p.m.
Can we move this comment above the reviewRequestURL definition?	david	April 19, 2026, 8:27 p.m.
This will need to be the full module path.	chipx86	April 21, 2026, 12:17 a.m.
Can you surround the data attribute name with double backticks?	chipx86	April 21, 2026, 12:37 a.m.
Since we're just computing the prefix, maybe we should do: const url = $target.data('review-request-url') \|\| $target.attr('href'); return `${url}infobox/`;	chipx86	April 21, 2026, 12:38 a.m.

flake8 passed.

JSHint passed.

reviewboard/datagrids/columns.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should be SafeString not str
```

reviewboard/datagrids/columns.py (Diff revision 1)

The issue has been resolved. Show all issues

We're not expecting any exceptions from get_absolute_url, so this could be a bit simpler:

render_context['review_request_url'] = \
    obj.review_request.get_absolute_url()

try:
    return super().render_cell(state, obj, render_context)
finally:
    del render_context['review_request_url']

reviewboard/static/rb/js/ui/views/reviewRequestInfoboxView.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

This needs "Args" and "Returns"

reviewboard/static/rb/js/ui/views/reviewRequestInfoboxView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we move this comment above the reviewRequestURL definition?
```

Commits:

	Summary	ID
	Fix a bug with the Review Summary column. In our recent datagrid updates, we gave the `ReviewSummaryColumn` a `link_css_class` of `review-request-link`. This is the class used for review request info boxes, which takes the cell's `href` target and uses that to create the review request info box. The `href` target for review summary cells is the review URL, but the review request info box requires a review request URL to work properly. This was causing a bug where the info box was populated with a poorly formatted review request page. Previously we didn't set the `link_css_class` for the `ReviewSummaryColumn`, which meant that the review request info box wouldn't show up when hovering over the review request summary of the column. This change fixes the bug and improves the behaviour, we now supply the review request URL to the info box through the column's render context and a custom template for the review summary cells.	fd5d0e2e0b207aac39dad28b28c74e89cf2bab78
	Fix a bug with the Review Summary column. In our recent datagrid updates, we gave the `ReviewSummaryColumn` a `link_css_class` of `review-request-link`. This is the class used for review request info boxes, which takes the cell's `href` target and uses that to create the review request info box. The `href` target for review summary cells is the review URL, but the review request info box requires a review request URL to work properly. This was causing a bug where the info box was populated with a poorly formatted review request page. Previously we didn't set the `link_css_class` for the `ReviewSummaryColumn`, which meant that the review request info box wouldn't show up when hovering over the review request summary of the column. This change fixes the bug and improves the behaviour, we now supply the review request URL to the info box through the column's render context and a custom template for the review summary cells.	7fe2edba1b28f94f169be92646272a944d5d4c93

Diff:

Revision 2 (+134 -2)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/static/rb/js/ui/views/reviewRequestInfoboxView.es6.js
	reviewboard/templates/datagrids/review_summary_cell.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/datagrids/columns.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This will need to be the full module path.
```

reviewboard/datagrids/columns.py (Diff revision 2)

I think this will be okay, but just to note, render_cell() does some caching based on a pre-set list of fields used for a key. This includes url but wouldn't include review_request_url. I assume though that this is fine because url should be more unique than review_request_url. Just want to verify my assumption on that.

maubin

April 21, 2026, 12:43 a.m.

Yes that's right, review_request_url shouldn't be included in the cache key it would just make the key longer with no benefit. The url used in the key is the review URL which is the review request url + the review ID.

reviewboard/static/rb/js/ui/views/reviewRequestInfoboxView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Can you surround the data attribute name with double backticks?
```

reviewboard/static/rb/js/ui/views/reviewRequestInfoboxView.es6.js (Diff revision 2)

The issue has been resolved. Show all issues

Since we're just computing the prefix, maybe we should do:

const url = $target.data('review-request-url') ||
            $target.attr('href');

return `${url}infobox/`;

Commits:

	Summary	ID
	Fix a bug with the Review Summary column. In our recent datagrid updates, we gave the `ReviewSummaryColumn` a `link_css_class` of `review-request-link`. This is the class used for review request info boxes, which takes the cell's `href` target and uses that to create the review request info box. The `href` target for review summary cells is the review URL, but the review request info box requires a review request URL to work properly. This was causing a bug where the info box was populated with a poorly formatted review request page. Previously we didn't set the `link_css_class` for the `ReviewSummaryColumn`, which meant that the review request info box wouldn't show up when hovering over the review request summary of the column. This change fixes the bug and improves the behaviour, we now supply the review request URL to the info box through the column's render context and a custom template for the review summary cells.	7fe2edba1b28f94f169be92646272a944d5d4c93
	Fix a bug with the Review Summary column. In our recent datagrid updates, we gave the `ReviewSummaryColumn` a `link_css_class` of `review-request-link`. This is the class used for review request info boxes, which takes the cell's `href` target and uses that to create the review request info box. The `href` target for review summary cells is the review URL, but the review request info box requires a review request URL to work properly. This was causing a bug where the info box was populated with a poorly formatted review request page. Previously we didn't set the `link_css_class` for the `ReviewSummaryColumn`, which meant that the review request info box wouldn't show up when hovering over the review request summary of the column. This change fixes the bug and improves the behaviour, we now supply the review request URL to the info box through the column's render context and a custom template for the review summary cells.	e27db99cdd21f4b40d3b2722ad7f9f8c19adf160

Branch:

release-7.1.x

release-8.x

Diff:

Revision 3 (+128 -2)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/static/rb/js/ui/views/reviewRequestInfoboxView.es6.js
	reviewboard/templates/datagrids/review_summary_cell.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-8.x (a55a977)