Summary

Use allowDeclareFields and fix prototypeAttrs.

Review Request #14998 — Created April 2, 2026 and submitted June 5, 2026, 4:56 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change turns on allowDeclareFields for @babel/preset-typescript
and fixes potential issues with any prototypeAttrs that might be
affected. This also adds in some missing type declarations for prototype
attrs.

A few places still had either duplicate prototypeAttrs (from back when
we had the spina bug about inheriting them) or just incorrect ones (e.g.
actionBuilders inside licenseModel, when it now actually exists on
the view). These have all been cleaned up.

Testing Done

Ran unit tests.

Commits

Summary	ID
Use allowDeclareFields and fix prototypeAttrs. This change turns on `allowDeclareFields` for `@babel/preset-typescript` and fixes potential issues with any `prototypeAttrs` that might be affected. This also adds in some missing type declarations for prototype attrs. A few places still had either duplicate `prototypeAttrs` (from back when we had the spina bug about inheriting them) or just incorrect ones (e.g. `actionBuilders` inside `licenseModel`, when it now actually exists on the view). These have all been cleaned up. Testing Done: Ran unit tests.	ntwnnplkmwktnposyuopxwxuvztplrxq

Summary

Use allowDeclareFields and fix prototypeAttrs.

This change turns on `allowDeclareFields` for `@babel/preset-typescript` and fixes potential issues with any `prototypeAttrs` that might be affected. This also adds in some missing type declarations for prototype attrs. A few places still had either duplicate `prototypeAttrs` (from back when we had the spina bug about inheriting them) or just incorrect ones (e.g. `actionBuilders` inside `licenseModel`, when it now actually exists on the view). These have all been cleaned up. Testing Done: Ran unit tests.

ntwnnplkmwktnposyuopxwxuvztplrxq

Issues

Description	From	Last Updated
Why do we keep the prototypeAttrs here.	maubin	June 4, 2026, 6:11 a.m.
How come we use AbstractCommentBlock in the static definition but TCommentBlockType in the declare.	maubin	June 4, 2026, 6:12 a.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/common/resources/models/reviewReplyModel.ts (Diff revision 1)

The issue has been dropped. Show all issues

Why do we keep the prototypeAttrs here.

david

June 4, 2026, 6:12 a.m.

We still want COMMENT_LINK_NAMES to get attached to the prototype. We no longer need to include the parent class' extraQueryArgs because that spina bug was fixed.

reviewboard/static/rb/js/reviews/models/abstractReviewableModel.ts (Diff revision 1)

The issue has been dropped. Show all issues

How come we use AbstractCommentBlock in the static definition but TCommentBlockType in the declare.

david

June 4, 2026, 6:12 a.m.

In TS, we can't use the generic TCommentBlockType for static members.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (cc94bc7)