Summary

Add setuptools as a dependency.

Review Request #14972 — Created March 26, 2026 and submitted March 26, 2026, 10:13 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

djblets.extensions.packaging uses setuptools, so we ought to define it
as a dependency.

Testing Done

Installed an env and ran tests without getting a failure here.

Commits

Summary	ID
Add setuptools as a dependency. `djblets.extensions.packaging` uses setuptools, so we ought to define it as a dependency. Testing Done: Installed an env and ran tests without getting a failure here.	rkzrmmsnrrtuntxztuzsvnkymnopyqns

Issues

Description	From	Last Updated
I'm not sure we need this per se. This comes into play when packaging an extension, at which point it's …	chipx86	March 26, 2026, 10:05 p.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

I'm not sure we need this per se. This comes into play when packaging an extension, at which point it's begin run within a build backend that already contains setuptools.

The setuptools-driven code is only executed from within a setuptools environment.

david March 26, 2026, 9:55 p.m.

It definitely gets exercised during unit tests. Perhaps a dev-dependency?

chipx86 March 26, 2026, 9:55 p.m.
```
Yeah, that'd be fine.
```

Commits:

	Summary	ID
	Add setuptools as a dependency. `djblets.extensions.packaging` uses setuptools, so we ought to define it as a dependency. Testing Done: Installed an env and ran tests without getting a failure here.	rkzrmmsnrrtuntxztuzsvnkymnopyqns
	Add setuptools as a dependency. `djblets.extensions.packaging` uses setuptools, so we ought to define it as a dependency. Testing Done: Installed an env and ran tests without getting a failure here.	rkzrmmsnrrtuntxztuzsvnkymnopyqns

Branch:

release-5.2.x

release-5.x

Diff:

Revision 2 (+2)

Show changes

dev-requirements.txt

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.2.x (94a0333)