Summary

Fix FieldError trying to sort the reviews datagrid on review_summary.

Review Request #14966 — Created March 26, 2026 and submitted March 26, 2026, 1:30 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The ReviewSummaryColumn was marked as sortable, but that was a
mistake. This change removes that flag so we don't trigger FieldError
due to the lack of a get_sort_field.

Testing Done

Opened a reviews datagrid with ?sort=review_summary and verified that it
didn't crash.

Commits

Summary	ID
Fix FieldError trying to sort the reviews datagrid on review_summary. The `ReviewSummaryColumn` was marked as sortable, but that was a mistake. This change removes that flag so we don't trigger FieldError due to the lack of a `get_sort_field`. Testing Done: Opened a reviews datagrid with ?sort=review_summary and verified that it didn't crash.	nlytvypuxskokyptnnzqxtuukwmuqynp

Issues

Description	From	Last Updated
Being sortable was a mistake. This would be an expensive sort, so I think we should just disable sorting here.	chipx86	March 26, 2026, 12:32 p.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Being sortable was a mistake. This would be an expensive sort, so I think we should just disable sorting here.

Description:

~		The `ReviewSummaryColumn` now lists itself as sortable, but it does not
~		map directly to a field name and did not define `get_sort_field`. This
~		was causing crashes when it was included in the sort list for the
	~	The `ReviewSummaryColumn` was marked as sortable, but that was a
	~	mistake. This change removes that flag so we don't trigger FieldError
	~	due to the lack of a `get_sort_field`.
-		datagrid.
-
-		This change adds a `get_sort_field` implementation that properly maps to
-		the review request summary.

Testing Done:

~		Sorted by "Review Request Summary" in a reviews datagrid and saw that it
~		no longer crashed, and that ascending/descending sort worked as
	~	Opened a reviews datagrid with ?sort=review_summary and verified that it
	~	didn't crash.
-		expected.

Commits:

	Summary	ID
	Fix FieldError trying to sort the reviews datagrid on review_summary. The `ReviewSummaryColumn` now lists itself as sortable, but it does not map directly to a field name and did not define `get_sort_field`. This was causing crashes when it was included in the sort list for the datagrid. This change adds a `get_sort_field` implementation that properly maps to the review request summary. Testing Done: Sorted by "Review Request Summary" in a reviews datagrid and saw that it no longer crashed, and that ascending/descending sort worked as expected.	nlytvypuxskokyptnnzqxtuukwmuqynp
	Fix FieldError trying to sort the reviews datagrid on review_summary. The `ReviewSummaryColumn` was marked as sortable, but that was a mistake. This change removes that flag so we don't trigger FieldError due to the lack of a `get_sort_field`. Testing Done: Opened a reviews datagrid with ?sort=review_summary and verified that it didn't crash.	nlytvypuxskokyptnnzqxtuukwmuqynp

Diff:

Revision 2 (-2)

Show changes

reviewboard/datagrids/columns.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (470a79a)