Summary

Modernize datagrid columns, fix bugs, and add JSON serialization.

Review Request #14844 — Created Feb. 21, 2026 and submitted March 19, 2026, 6:13 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

~~14843~~

Reviewers

Groups

reviewboard

People

Description

This is a major update to the existing datagrid columns, largely
preparing them for the new Dashboard API resource, and fixing up a
number of issues in their implementation.

All columns now provide a stable JSON representation that can be used in
the API, returning structured data, API-compatible objects (which will
be turned into payloads or links), or raw values.

In some cases, this is done by overriding the new to_json(), but in
most we just now calculate the state for both the JSON and HTML
representations in the column-controlled get_raw_object_value(). This
keeps the data calculation in one place, and simplifies both output
functions (often using default logic).

HTML rendering has been fixed in all places to correctly use
format_html() or escape() for results. This will future-proof these
columns for when the datagrid code starts escaping non-SafeStrings.

Most of the __init__() methods are now gone, instead using the new
class-defined attributes. This is much easier to maintain and
specialize.

Types have been fixed and annotated all throughout, catching issues in
some of the logic.

Many bugs (such as extra spaces at the end of values, wrong data types
being returned where strings are expected) that weren't previously
caught have been fixed, with tests updated to strictly check return
types.

Testing Done

Unit tests pass.

Tested all columns in the dashboard in both the browser and with
a test script using the in-progress dashboard API.

Commits

Summary	ID
Modernize datagrid columns, fix bugs, and add JSON serialization. This is a major update to the existing datagrid columns, largely preparing them for the new Dashboard API resource, and fixing up a number of issues in their implementation. All columns now provide a stable JSON representation that can be used in the API, returning structured data, API-compatible objects (which will be turned into payloads or links), or raw values. In some cases, this is done by overriding the new `to_json()`, but in most we just now calculate the state for both the JSON and HTML representations in the column-controlled `get_raw_object_value()`. This keeps the data calculation in one place, and simplifies both output functions (often using default logic). HTML rendering has been fixed in many places to correctly use `format_html()` when we're constructing actual HTML to display. This will future-proof these columns for when the datagrid code starts escaping non-SafeStrings. Most of the `__init__()` methods are now gone, instead using the new class-defined attributes. This is much easier to maintain and specialize. Types have been fixed and annotated all throughout, catching issues in some of the logic. Many bugs (such as extra spaces at the end of values, wrong data types being returned where strings are expected) that weren't previously caught have been fixed, with tests updated to strictly check return types.	72d15e72a7b1924eebb0dc388815883dbbb0e2fd

Summary

Modernize datagrid columns, fix bugs, and add JSON serialization.

This is a major update to the existing datagrid columns, largely preparing them for the new Dashboard API resource, and fixing up a number of issues in their implementation. All columns now provide a stable JSON representation that can be used in the API, returning structured data, API-compatible objects (which will be turned into payloads or links), or raw values. In some cases, this is done by overriding the new `to_json()`, but in most we just now calculate the state for both the JSON and HTML representations in the column-controlled `get_raw_object_value()`. This keeps the data calculation in one place, and simplifies both output functions (often using default logic). HTML rendering has been fixed in many places to correctly use `format_html()` when we're constructing actual HTML to display. This will future-proof these columns for when the datagrid code starts escaping non-SafeStrings. Most of the `__init__()` methods are now gone, instead using the new class-defined attributes. This is much easier to maintain and specialize. Types have been fixed and annotated all throughout, catching issues in some of the logic. Many bugs (such as extra spaces at the end of values, wrong data types being returned where strings are expected) that weren't previously caught have been fixed, with tests updated to strictly check return types.

72d15e72a7b1924eebb0dc388815883dbbb0e2fd

Issues

Description	From	Last Updated
This should be bool	david	March 3, 2026, 8:52 p.m.
This should be list of dict and explain what the dict return value contains.	david	March 4, 2026, 12:58 a.m.
We should use a walrus operator to pull out diffset_history and last_diff_updated instead of accessing them each time.	maubin	March 4, 2026, 1:11 a.m.
This should be Group	david	March 4, 2026, 12:58 a.m.
This should just say "The review request being ..."	maubin	March 4, 2026, 1:12 a.m.
These should probably have a default of None	david	March 4, 2026, 1:04 a.m.
This is returning an unclosed <div>	david	March 4, 2026, 1 a.m.
This should be Group	david	March 4, 2026, 1 a.m.
This should probably pass a default of 0	david	March 4, 2026, 1:03 a.m.
This should probably have a default of ''	david	March 4, 2026, 1:03 a.m.
This should probably have a default of VISIBLE	david	March 4, 2026, 1:03 a.m.
This description doesn't apply here.	maubin	March 4, 2026, 1:12 a.m.
This wasn't sortable before, but is now. I don't think that was intentional given the contents of this column.	david	March 4, 2026, 1:04 a.m.
This looks like it's supposed to be the description for the ToMeColumn, we should move it there.	maubin	March 4, 2026, 1:13 a.m.
This was copy/pasted from BugsColumn without being updated.	david	March 4, 2026, 1:06 a.m.
Typos: josn -> json	david	March 4, 2026, 1:10 a.m.
Typos: josn -> json	david	March 4, 2026, 1:11 a.m.
'django.utils.html.conditional_escape' imported but unused Column: 1 Error code: F401	reviewbot	March 10, 2026, 12:21 a.m.
We're no longer setting link_func. It seems like Column.__init__ will set it to the datagrid's link_to_object, not the column's link_to_object.	david	March 10, 2026, 12:19 a.m.
This should be called "group" instead of "user"	david	March 10, 2026, 12:19 a.m.
We're using getattr without defaults, which could raise AttributeError. Seems like maybe we want to default to False?	david	March 10, 2026, 12:20 a.m.
Same here re: link_func	david	March 10, 2026, 12:21 a.m.
Another getattr without a default.	david	March 10, 2026, 12:20 a.m.
Another getattr without a default.	david	March 10, 2026, 12:20 a.m.
Another getattr without a default.	david	March 10, 2026, 12:20 a.m.
This was copy/pasted from something else.	david	March 10, 2026, 12:20 a.m.

flake8 passed.

JSHint passed.

reviewboard/datagrids/columns.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should be bool
```
reviewboard/datagrids/columns.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should be list of dict and explain what the dict return value contains.
```
reviewboard/datagrids/columns.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should be Group
```

reviewboard/datagrids/columns.py (Diff revision 1)

The issue has been dropped. Show all issues

These should probably have a default of None

chipx86

March 5, 2026, 4 a.m.

Here and others below are all safe. If we end up in a situation where this field isn't there, then the entire datagrid queryset machinery is broken, and it's useful to know that.

reviewboard/datagrids/columns.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This is returning an unclosed <div>
```
reviewboard/datagrids/columns.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should be Group
```
reviewboard/datagrids/columns.py (Diff revision 1)
The issue has been dropped. Show all issues
```
This should probably pass a default of 0
```
reviewboard/datagrids/columns.py (Diff revision 1)
The issue has been dropped. Show all issues
```
This should probably have a default of ''
```
reviewboard/datagrids/columns.py (Diff revision 1)
The issue has been dropped. Show all issues
```
This should probably have a default of VISIBLE
```

reviewboard/datagrids/columns.py (Diff revision 1)

The issue has been resolved. Show all issues

This wasn't sortable before, but is now. I don't think that was intentional given the contents of this column.

reviewboard/datagrids/columns.py (Diff revision 1)

The issue has been resolved. Show all issues

This was copy/pasted from BugsColumn without being updated.

reviewboard/datagrids/tests/test_full_name_column.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Typos: josn -> json
```
reviewboard/datagrids/tests/test_ship_it_column.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Typos: josn -> json
```

reviewboard/datagrids/columns.py (Diff revision 1)

The issue has been resolved. Show all issues

We should use a walrus operator to pull out diffset_history and last_diff_updated instead of accessing them each time.

reviewboard/datagrids/columns.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should just say "The review request being ..."
```
reviewboard/datagrids/columns.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This description doesn't apply here.
```

reviewboard/datagrids/columns.py (Diff revision 1)

The issue has been resolved. Show all issues

This looks like it's supposed to be the description for the ToMeColumn, we should move it there.

Change Summary:


Fixed several doc issues and typos.
Fixed bad rendering of the Diff Last Updated column value and improved tests there.
Added specific types for some of the raw values.
Fixed unclosed HTML tags.
Reverted being able to sort the Diff Size column. This was accidental.
Made use of a walrus operator to pull data out for the Diff Last Updated value.

Commits:

	Summary	ID
	Modernize datagrid columns, fix bugs, and add JSON serialization. This is a major update to the existing datagrid columns, largely preparing them for the new Dashboard API resource, and fixing up a number of issues in their implementation. All columns now provide a stable JSON representation that can be used in the API, returning structured data, API-compatible objects (which will be turned into payloads or links), or raw values. In some cases, this is done by overriding the new `to_json()`, but in most we just now calculate the state for both the JSON and HTML representations in the column-controlled `get_raw_object_value()`. This keeps the data calculation in one place, and simplifies both output functions (often using default logic). HTML rendering has been fixed in many places to correctly use `format_html()` when we're constructing actual HTML to display. This will future-proof these columns for when the datagrid code starts escaping non-SafeStrings. Most of the `__init__()` methods are now gone, instead using the new class-defined attributes. This is much easier to maintain and specialize. Types have been fixed and annotated all throughout, catching issues in some of the logic. Many bugs (such as extra spaces at the end of values, wrong data types being returned where strings are expected) that weren't previously caught have been fixed, with tests updated to strictly check return types.	826620197224da1889c20928695d233654abe1f7
	Modernize datagrid columns, fix bugs, and add JSON serialization. This is a major update to the existing datagrid columns, largely preparing them for the new Dashboard API resource, and fixing up a number of issues in their implementation. All columns now provide a stable JSON representation that can be used in the API, returning structured data, API-compatible objects (which will be turned into payloads or links), or raw values. In some cases, this is done by overriding the new `to_json()`, but in most we just now calculate the state for both the JSON and HTML representations in the column-controlled `get_raw_object_value()`. This keeps the data calculation in one place, and simplifies both output functions (often using default logic). HTML rendering has been fixed in many places to correctly use `format_html()` when we're constructing actual HTML to display. This will future-proof these columns for when the datagrid code starts escaping non-SafeStrings. Most of the `__init__()` methods are now gone, instead using the new class-defined attributes. This is much easier to maintain and specialize. Types have been fixed and annotated all throughout, catching issues in some of the logic. Many bugs (such as extra spaces at the end of values, wrong data types being returned where strings are expected) that weren't previously caught have been fixed, with tests updated to strictly check return types.	0bc60fb26398a6b7df0d21751a62516979d1a68a

Diff:

Revision 2 (+5330 -1122)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/datagrids/tests/base.py
	reviewboard/datagrids/tests/test_bugs_column.py
	reviewboard/datagrids/tests/test_diff_size_column.py
	reviewboard/datagrids/tests/test_diff_updated_column.py
	reviewboard/datagrids/tests/test_diff_updated_since_column.py
	reviewboard/datagrids/tests/test_full_name_column.py
	reviewboard/datagrids/tests/test_group_member_count_column.py
	16 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/datagrids/columns.py (Diff revision 2)

The issue has been resolved. Show all issues

'django.utils.html.conditional_escape' imported but unused

Column: 1
Error code: F401

reviewboard/datagrids/columns.py (Diff revision 2)

The issue has been resolved. Show all issues

We're no longer setting link_func. It seems like Column.__init__ will set it to the datagrid's link_to_object, not the column's link_to_object.

reviewboard/datagrids/columns.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This should be called "group" instead of "user"
```

reviewboard/datagrids/columns.py (Diff revision 2)

The issue has been dropped. Show all issues

We're using getattr without defaults, which could raise AttributeError. Seems like maybe we want to default to False?

chipx86

March 10, 2026, 12:23 a.m.

These are correct and discussed in the prior review when you flagged these. These are provided as part of the queryset. If these blow up, something fundamentally broke with the datagrids preparation procedures, and we absolutely want to know that.

reviewboard/datagrids/columns.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Same here re: link_func
```
reviewboard/datagrids/columns.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Another getattr without a default.
```
reviewboard/datagrids/columns.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Another getattr without a default.
```
reviewboard/datagrids/columns.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Another getattr without a default.
```
reviewboard/datagrids/columns.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This was copy/pasted from something else.
```

Change Summary:


Restored the broken link_func values.
Fixed some bad docs.
Fixed an incorrect variable name.

Commits:

	Summary	ID
	Modernize datagrid columns, fix bugs, and add JSON serialization. This is a major update to the existing datagrid columns, largely preparing them for the new Dashboard API resource, and fixing up a number of issues in their implementation. All columns now provide a stable JSON representation that can be used in the API, returning structured data, API-compatible objects (which will be turned into payloads or links), or raw values. In some cases, this is done by overriding the new `to_json()`, but in most we just now calculate the state for both the JSON and HTML representations in the column-controlled `get_raw_object_value()`. This keeps the data calculation in one place, and simplifies both output functions (often using default logic). HTML rendering has been fixed in many places to correctly use `format_html()` when we're constructing actual HTML to display. This will future-proof these columns for when the datagrid code starts escaping non-SafeStrings. Most of the `__init__()` methods are now gone, instead using the new class-defined attributes. This is much easier to maintain and specialize. Types have been fixed and annotated all throughout, catching issues in some of the logic. Many bugs (such as extra spaces at the end of values, wrong data types being returned where strings are expected) that weren't previously caught have been fixed, with tests updated to strictly check return types.	0bc60fb26398a6b7df0d21751a62516979d1a68a
	Modernize datagrid columns, fix bugs, and add JSON serialization. This is a major update to the existing datagrid columns, largely preparing them for the new Dashboard API resource, and fixing up a number of issues in their implementation. All columns now provide a stable JSON representation that can be used in the API, returning structured data, API-compatible objects (which will be turned into payloads or links), or raw values. In some cases, this is done by overriding the new `to_json()`, but in most we just now calculate the state for both the JSON and HTML representations in the column-controlled `get_raw_object_value()`. This keeps the data calculation in one place, and simplifies both output functions (often using default logic). HTML rendering has been fixed in many places to correctly use `format_html()` when we're constructing actual HTML to display. This will future-proof these columns for when the datagrid code starts escaping non-SafeStrings. Most of the `__init__()` methods are now gone, instead using the new class-defined attributes. This is much easier to maintain and specialize. Types have been fixed and annotated all throughout, catching issues in some of the logic. Many bugs (such as extra spaces at the end of values, wrong data types being returned where strings are expected) that weren't previously caught have been fixed, with tests updated to strictly check return types.	72d15e72a7b1924eebb0dc388815883dbbb0e2fd

Diff:

Revision 3 (+5332 -1124)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/datagrids/tests/base.py
	reviewboard/datagrids/tests/test_bugs_column.py
	reviewboard/datagrids/tests/test_diff_size_column.py
	reviewboard/datagrids/tests/test_diff_updated_column.py
	reviewboard/datagrids/tests/test_diff_updated_since_column.py
	reviewboard/datagrids/tests/test_full_name_column.py
	reviewboard/datagrids/tests/test_group_member_count_column.py
	16 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (73c49fc)