Summary

Add unit tests for nearly all datagrid columns.

Review Request #14843 — Created Feb. 20, 2026 and updated March 8, 2026, 9:06 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Blocks

14844

Reviewers

Groups

reviewboard

People

Description

We were lacking tests for most datagrid columns, and this meant that we

didn't catch a series of implementation issues, such as a mixture of

safe and non-safe strings for HTML, non-string return types for

rendering (integers and a Repository instance in one case).
Upcoming work will be addressing these and adding support required for

a dashboard API resource. To prepare for that, and to provide a good

base for upcoming fixes, this change fleshes out our datagrid column

test suite to cover all columns but the Repository column (which can't

easily be tested without those fixes).

Testing Done

Unit tests pass.

Commits

Summary	ID
Add unit tests for nearly all datagrid columns. We were lacking tests for most datagrid columns, and this meant that we didn't catch a series of implementation issues, such as a mixture of safe and non-safe strings for HTML, non-string return types for rendering (integers and a `Repository` instance in one case). Upcoming work will be addressing these and adding support required for a dashboard API resource. To prepare for that, this change fleshes out our datagrid column test suite to cover all columns but the Repository column (which can't easily be tested without the upcoming fixes).	177b35f8fe69492b431f5813630a3f4d8e4fd649

Summary

Add unit tests for nearly all datagrid columns.

We were lacking tests for most datagrid columns, and this meant that we didn't catch a series of implementation issues, such as a mixture of safe and non-safe strings for HTML, non-string return types for rendering (integers and a `Repository` instance in one case). Upcoming work will be addressing these and adding support required for a dashboard API resource. To prepare for that, this change fleshes out our datagrid column test suite to cover all columns but the Repository column (which can't easily be tested without the upcoming fixes).

177b35f8fe69492b431f5813630a3f4d8e4fd649

Issues

Description	From	Last Updated
'django.utils.safestring.SafeString' imported but unused Column: 1 Error code: F401	reviewbot	Feb. 20, 2026, 4:30 p.m.
Can we have the class docstrings match what the module docstring says ("Unit tests for ...")? Same for the others.	david	March 3, 2026, 12:49 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/datagrids/tests/test_diff_size_column.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'django.utils.safestring.SafeString' imported but unused

Column: 1
Error code: F401
```

Change Summary:

Removed an unused import.

Commits:

	Summary	ID
	Add unit tests for nearly all datagrid columns. We were lacking tests for most datagrid columns, and this meant that we didn't catch a series of implementation issues, such as a mixture of safe and non-safe strings for HTML, non-string return types for rendering (integers and a `Repository` instance in one case). Upcoming work will be addressing these and adding support required for a dashboard API resource. To prepare for that, this change fleshes out our datagrid column test suite to cover all columns but the Repository column (which can't easily be tested without the upcoming fixes).	7c40c1a9ebef05796c853f412d4b1db1cf32c573
	Add unit tests for nearly all datagrid columns. We were lacking tests for most datagrid columns, and this meant that we didn't catch a series of implementation issues, such as a mixture of safe and non-safe strings for HTML, non-string return types for rendering (integers and a `Repository` instance in one case). Upcoming work will be addressing these and adding support required for a dashboard API resource. To prepare for that, this change fleshes out our datagrid column test suite to cover all columns but the Repository column (which can't easily be tested without the upcoming fixes).	ce0bd5964a7b9232457f49bb6d313cc63739f7fa

Diff:

Revision 2 (+2042)

Show changes

	reviewboard/datagrids/tests/test_bugs_column.py
	reviewboard/datagrids/tests/test_diff_size_column.py
	reviewboard/datagrids/tests/test_diff_updated_column.py
	reviewboard/datagrids/tests/test_diff_updated_since_column.py
	reviewboard/datagrids/tests/test_group_member_count_column.py
	reviewboard/datagrids/tests/test_groups_column.py
	reviewboard/datagrids/tests/test_my_comments_column.py
	reviewboard/datagrids/tests/test_new_updates_column.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/datagrids/tests/test_bugs_column.py (Diff revision 2)

The issue has been resolved. Show all issues

Can we have the class docstrings match what the module docstring says ("Unit tests for ...")? Same for the others.

chipx86 March 3, 2026, 12:51 p.m.

Yeah, not sure how I ended up with that format. Bad start and copy/paste.

Change Summary:

Updated the testcase class docs to use our standard format.

Commits:

	Summary	ID
	Add unit tests for nearly all datagrid columns. We were lacking tests for most datagrid columns, and this meant that we didn't catch a series of implementation issues, such as a mixture of safe and non-safe strings for HTML, non-string return types for rendering (integers and a `Repository` instance in one case). Upcoming work will be addressing these and adding support required for a dashboard API resource. To prepare for that, this change fleshes out our datagrid column test suite to cover all columns but the Repository column (which can't easily be tested without the upcoming fixes).	ce0bd5964a7b9232457f49bb6d313cc63739f7fa
	Add unit tests for nearly all datagrid columns. We were lacking tests for most datagrid columns, and this meant that we didn't catch a series of implementation issues, such as a mixture of safe and non-safe strings for HTML, non-string return types for rendering (integers and a `Repository` instance in one case). Upcoming work will be addressing these and adding support required for a dashboard API resource. To prepare for that, this change fleshes out our datagrid column test suite to cover all columns but the Repository column (which can't easily be tested without the upcoming fixes).	177b35f8fe69492b431f5813630a3f4d8e4fd649

Diff:

Revision 3 (+2050 -8)

Show changes

	reviewboard/datagrids/tests/test_bugs_column.py
	reviewboard/datagrids/tests/test_diff_size_column.py
	reviewboard/datagrids/tests/test_diff_updated_column.py
	reviewboard/datagrids/tests/test_diff_updated_since_column.py
	reviewboard/datagrids/tests/test_full_name_column.py
	reviewboard/datagrids/tests/test_group_member_count_column.py
	reviewboard/datagrids/tests/test_groups_column.py
	reviewboard/datagrids/tests/test_my_comments_column.py
	13 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```