• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Introduce bot for typos
    
 
    

    



 
    
 
    

  Review Request #14817
  —
  Created Feb. 12, 2026 and updated 

 
    


    




    




    






 
    
  
    
   Information

  
    



    
 
 
    
  misery
 
    

    





    
 
 
    
  ReviewBot
 
    

    





    
 
 
    
  master
 
    

    





    
 
 
    
  4974
 
    

    





    
 
 
    
  14900
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewbot
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    Introduce bot for typos
    
 
    

    





  

    
 
 
    
  
    Add two files with typos and saw that the exclude file had no issues from the bot. The other files got issues.
    
 
    

    




 
    

    





    
 
    




  
    
 
 
    
  


    
 
    
  
   
    

    Summary
    ID

   
    
      
  

   
    

    

     
    Introduce bot for typos
    

        		
    0b7ec6e263611c2da68541e2ee09424ec5114d20

   
    


      
 
    

    
    
 
    

    






 





    
 
 
 
    
  
    
   
    
    
    
     
    
    
    
      
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
    
    
   
    
   
    
    
     
    
      Description
      From
      Last Updated
     
    
        
    



     
    
      
       
       
    If someone has an exclude for something like this with an explicity subdirectory the excludes won't work because ReviewBot uses …
    
          		
      
       miserymisery
      
      
       
      
     
    



     
    
      
       
       
    line too long (101 > 79 characters) Column: 80 Error code: E501
    
          		
      
       reviewbotreviewbot
      
      
       
      
     
    

        
   
    
  
    
 
    

    




 
    

    



  
    
 
    

    


    












    
 




 
    
  
    

   
    
   
    
    
     
Checks run (1 failed, 1 succeeded)

    
    
   
    

  
    
  
    
  
    


    

 
    
 flake8
 failed.
 


    


 
    
 JSHint
 passed.
 


    



    





    
 
    flake8
    
 
    

 

    








  
    
 
    

    


 













    
 



 
    
  
    
   
    



misery




   
    
   
    
  
    
 
    


 

    












    
 



 
    
  
    
   
    



misery




   
    
   
    
  
    
 
    


 

    












    
 



 
    
  
    
   
    



misery




   
    
   
    
  
    
 
    


 

    












    
 



 
    
  
    
   
    



misery




   
    
   
    
  
    
 
    


 

    












    
 



 
    
  
    
   
    



misery




   
    
   
    
  
    
 
    


 

    












    
 



 
    
  
    
   
    



misery




   
    
   
    
  
    
 
    


 

    












    
 



 
    
  
    
   
    



misery




   
    
   
    
  
    
 
    


 

    












    
 





 
    
  
    
   
    



misery




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
misery


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 







    2. 
 
      
  
  
      
  
   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      If someone has an exclude for something like this with an explicity subdirectory the excludes won't work because ReviewBot uses another "root directory".
      
Is this something that could be changed in ReviewBot? It is quite annoying to change excludes because for temporary directories of the bot.
      

      

      [files]
extend-exclude = [
    "src/external/**",
]

      

      

      

      This is a work-around:
      

      [files]
extend-exclude = [
    "*/src/external/**",
]

      
  
      
 
      

 
      
  


      
 
      
 
        

  


      1. 
 
 
        
 
        
  
 
        
 
        
  
        Well, the work-around isn't working good.....
        
 
        

        2. 



      2. 
 
 
        
 
        
  
 
        
 
        
  
        Tried in in ruff checker, too.
        

        

         - [WARNING] celery.redirected: cwd: /home/andre/git/ReviewBot/bot
 - [WARNING] celery.redirected: /tmp/tmpkabayizf/patch.py
 - [WARNING] celery.redirected: /tmp/tmpnb1bskxh/patch.py
 - [WARNING] celery.redirected: ['ruff', 'check', '--output-format=json', '--force-exclude', '--config', '/tmp/tmpge3nagc1', '/tmp/tmpkabayizf/patch.py', '/tmp/tmpnb1bskxh/patch.py']
 - [ERROR] reviewbot.tools.ruff: Failed to parse ruff output as JSON: warning: No Python files found under the given path(s)
[]

        

        Every patched file uses it's own path.
        

        

        In the changeset are those files:
        

        patch.py
test/bla/patch.py

        

        Is it possible to get the same directory structure (with switched cwd) in the bot to have working excludes? Maybe get_patched_file_path could get optional parameters for this like use_subdirectories and use_given_temp_dir or something like this. So the bot can create it's own temporary directory, add any patched file into it and executes the tool with that cwd.
        
 
        

        3. 



      3. 
 
 
        
 
        
  
 
        
 
        
  
        /r/14900/
        
 
        

        4. 


 
      


      

 
      

      3. 













    3. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      4. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



misery




   
    
   
    
  
    
 
    


 
    
  
    

   
    
   
    
    
     Review request changed
    
    
   
    

  
    
  
    
  
    




    









  
    
   
    
    Commits:
   
    
   
    
    
    



    
 
    
  
   
    

    

    Summary
    ID

   
    
      
  

   
    

    

    

     
    Introduce bot for typos
    

        		
    14c207aae8dea63a9fe7cdedcf1c72170979f6f8

   
    



   
    

    

    

     
    Introduce bot for typos
    

        		
    0b7ec6e263611c2da68541e2ee09424ec5114d20

   
    


      
 
    

    


    

   
    
  
    




  
    
   
    
    Depends On:
   
    
   
    
    
    14900 - Add possibilty to use a custom tempdir and full directory structure
    
   
    
  
    




  
    
   
    
    Diff:
   
    
   
    
    
     Revision 8 (+310)
    Show changes
     
        bot/setup.py 
        bot/reviewbot/tools/typos.py 
     
    
   
    
  
    





    



    
 
    
  
    Checks run (2 succeeded)
    


  
    
 flake8
 passed.
 


    


  
    
 JSHint
 passed.