- Download Diff

Summary:

Add --git-patchset option

Review Request #1472 — Created March 11, 2010 and discarded Sept. 28, 2012, 1:29 p.m.

Information
Owner:	sgallagh
Repository:	RBTools
Branch:
Bugs:
Depends On:
Reviewers
Groups:	rbtools
People:

Description

Add --git-patchset option

This option will generate a series of review requests, one for
each git commit in the current branch since the upstream merge
base.

Testing Done

This patch was used to generate the review request for itself :)

I also tested it with a five-patch series I had in my own personal git repo for another project.

Ship it!

```
wer
```
1. MY
  
  mytest March 14, 2010, 3:05 p.m.
  wer

Groups:

-	reviewboard
+	rbtools

Would also be great if you could add a test case :)

rbtools/postreview.py (Diff revision 1)

Should probably make these into methods now that they are used in multiple places (also in guess-summary, guess-description)

sgallagh March 23, 2010, 12:08 a.m.
```
Will do. New patch forthcoming.
```

rbtools/postreview.py (Diff revision 1)

It doesn't look like this is used anywhere and I'm not sure what its purpose would be? Can you explain?

sgallagh March 23, 2010, 12:07 a.m.

Whoops, this was part of a separate patch I was working on. That shouldn't have been part of this diff. I will remove it in the next version.

Change Summary:

Added GitClient.get_summary() and GitClient.get_description. Updated GitClient.get_patchset() and GitClient.diff() to use these routines.

Removed references to --git-remote.

Diff:

Revision 2 (+78 -8)

Show changes

rbtools/postreview.py

RB doesn't seem to like the new diff... did you use your post-review to upload it? :)

sgallagh March 23, 2010, 6:06 a.m.

No, I just updated the amended git diff by doing 'git commit --amend; git format-patch -1' and then uploading it via the "Update Diff" link on the review.

Is that the wrong way to do it? Was it supposed to be a follow-up diff, rather than a replacement?

I just used my patch to submit a brand-new review request ( http://reviews.reviewboard.org/r/1481/ ) which seems to have worked just fine. Maybe I just don't understand the workflow for updating diffs.

chipx86 March 23, 2010, 6:08 a.m.

There aren't any SHA1s in that diff, so Review Board can't access anything. Best to use post-review or git diff --full-index.

Change Summary:

Attaching a proper diff. The previous attempt was missing sha1 sums.

Diff:

Revision 3 (+78 -8)

Show changes

rbtools/postreview.py

Change Summary:

Added tests for --git-patchset

Diff:

Revision 4 (+167 -8)

Show changes

	rbtools/postreview.py
	rbtools/tests.py

Ship it!

You have a pending review.

Review Board 5.0.2 alpha 0 (dev)

Add --git-patchset option

Groups:

Change Summary:

Diff:

Change Summary:

Diff:

Change Summary:

Diff:

Status: Discarded