Summary

Add action renderers for sidebars.

Review Request #14716 — Created Nov. 29, 2025 and updated Dec. 3, 2025, 1:34 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This introduces two new renderers used for sidebars: One for groups
(which recurses into subgroups), and one for items.

The renderers fit into the existing rb-c-sidebar styling. This has
been updated to support subgroups in the sidebar, which appear with a
bold (but not uppercase) header and nested items.

This in preparation for action registration for admin sidebar items,
which will allow extensions to augment the sidebar.

Testing Done

Unit tests pass.

Tested with an upcoming change converting the admin UI to the sidebar.

Commits

Summary	ID
Add action renderers for sidebars. This introduces two new renderers used for sidebars: One for groups (which recurses into subgroups), and one for items. The renderers fit into the existing `rb-c-sidebar` styling. This has been updated to support subgroups in the sidebar, which appear with a bold (but not uppercase) header and nested items. This in preparation for action registration for admin sidebar items, which will allow extensions to augment the sidebar.	ec50a6d498b8261721eb1bdcb873e6de54420672

Summary

Add action renderers for sidebars.

This introduces two new renderers used for sidebars: One for groups (which recurses into subgroups), and one for items. The renderers fit into the existing `rb-c-sidebar` styling. This has been updated to support subgroups in the sidebar, which appear with a bold (but not uppercase) header and nested items. This in preparation for action registration for admin sidebar items, which will allow extensions to augment the sidebar.

ec50a6d498b8261721eb1bdcb873e6de54420672

Files

Issues

Description	From	Last Updated
Can we add a test to verify that this URL matching works as expected?	david	Dec. 3, 2025, 1:34 a.m.
Can we prefix these with _ to mark them as internal? Otherwise future linting will complain about missing docstrings. (and/or …	david	Dec. 3, 2025, 1:34 a.m.
group_action.html defines this as already including {{action_attrs}}. From the unit tests it seems like this starts out empty, but it …	david	Dec. 3, 2025, 1:34 a.m.
This should be aria-labelledby (no second hyphen)	david	Dec. 3, 2025, 1:34 a.m.

flake8 passed.

JSHint passed.

Fix it!

reviewboard/actions/renderers.py (Diff revision 1)
An issue was opened. Show all issues
```
Can we add a test to verify that this URL matching works as expected?
```

reviewboard/actions/tests/test_sidebar_action_group_renderer.py (Diff revision 1)

An issue was opened. Show all issues

Can we prefix these with _ to mark them as internal? Otherwise future linting will complain about missing docstrings.

(and/or we could add docstrings)

reviewboard/templates/actions/sidebar_group_action.html (Diff revision 1)

An issue was opened. Show all issues

group_action.html defines this as already including {{action_attrs}}. From the unit tests it seems like this starts out empty, but it seems like if anything is actually in there, by including both {{block.super}} and {{action_attrs}}, we'd get duplicate attributes (we actually might already with id=, and assertHTMLEqual's parsing is masking it).

reviewboard/templates/actions/sidebar_group_action.html (Diff revision 1)
An issue was opened. Show all issues
```
This should be aria-labelledby (no second hyphen)
```